CI: Run JavaScript tests on node 24 and restore package-lock.json - #287
Merged
Conversation
`npm ci` broke in the JavaScript workflow with
Missing: @emnapi/runtime@1.11.3 from lock file
The lock file was regenerated as a side effect of an unrelated commit and
lost the top-level `@emnapi/runtime` entry, which the optional peer
dependency of `@napi-rs/wasm-runtime` still requires; a clean `npm ci`
fails with both npm 10 and npm 11. `package.json` is unchanged, so the
previous lock file is restored verbatim.
The node version in the test matrix is bumped from 22 to 24 to match the
version pinned in the devbox development environment.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm cibroke in the JavaScript workflow withThe lock file was regenerated as a side effect of an unrelated commit and lost the top-level
@emnapi/runtimeentry, which the optional peer dependency of@napi-rs/wasm-runtimestill requires; a cleannpm cifails with both npm 10 and npm 11.package.jsonis unchanged, so the previous lock file is restored verbatim.The node version in the test matrix is bumped from 22 to 24 to match the version pinned in the devbox development environment.