This repository was archived by the owner on Jan 6, 2025. It is now read-only.
Fix flaky agentprotocol test#538
Merged
Merged
Conversation
Both testing threads called the Kill() function at the same time which caused them to deadlock as they both were trying to send the termination packet to each-other at the same time. In a real situation this would not cause a deadlock as the communication between the two sides would be buffered. Signed-off-by: Nikos Tsipinakis <nikos@tsipinakis.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes introduced with this PR
Both testing threads called the Kill() function at the same time which caused them to deadlock as they both were trying to send the termination packet to each-other at the same time. In a real situation this would not cause a deadlock as the communication between the two sides would be buffered.
By contributing to this repository, I agree to the contribution guidelines.