First MADRs for latest decisions #334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #334 +/- ##
========================================
Coverage 92.9% 92.9%
Complexity 2325 2325
========================================
Files 203 203
Lines 6263 6263
Branches 840 840
========================================
Hits 5824 5824
Misses 216 216
Partials 223 223 |
socadk
reviewed
May 4, 2023
Contributor
socadk
left a comment
socadk
left a comment
There was a problem hiding this comment.
Looks good, two suggestions/comments:
- UC AD: "the "defacto" standard book for UML" -> "a popular book on UML and OOAD, serving as a 'de-facto' standard for many modelers"
- UC AD: "because we usually tried to stick with the standard literature" -.> "because we try to use and align with the literature as such as possible"
Member
Author
|
Thanks @socadk, I adjusted the MADR as suggested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.