feat(payments): add CEP-8 authorization store - #104
Merged
ContextVM-org merged 1 commit intoJul 29, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #100
The next piece of CEP-8 explicit gating: the store that tracks which payments are in flight and which have been paid, keyed by the canonical identity from #103. Still pure. No middleware or transport yet, that comes in a later PR.
It's a separate PR because of the concurrency. ts-sdk gets away with a plain map since Node is single-threaded and its claim/trySetPending never await mid-operation, so nothing interleaves. We're on multi-threaded tokio, where two requests can hit claim on the same grant at the same time on two cores. So the store sits behind one std::sync::Mutex and each op does its whole check-and-mutate in a single critical section with no await inside. That's what stops one grant being claimed twice.
std::sync::Mutex on purpose, not tokio's: the sections never await, so an async lock adds nothing, and the std guard won't let an await creep in later either (it isn't Send, so it won't compile inside tokio::spawn and clippy catches it). Grants and pending are two separate LruCaches so they evict independently, 5000 each, with lazy Instant TTLs.
Tests are the 9 from the ts-sdk's own suite ported over, plus a couple that throw a bunch of tasks at a single grant and check exactly one wins.