fix(opencode): install system llvm tools for coverage sandbox - #1069
fix(opencode): install system llvm tools for coverage sandbox#1069seonghobae wants to merge 2 commits into
Conversation
The trusted coverage sandbox image ships cargo-llvm-cov but only apt cargo/rustc without rustup llvm-tools-preview. cargo-llvm-cov then fails with "failed to find llvm-tools-preview" on Rust workspaces (e.g. TEPP), blocking OpenCode approval despite green repository CI. Install the Debian llvm package, symlink llvm-cov/llvm-profdata into PATH, export LLVM_COV/LLVM_PROFDATA, and teach ensure_rust_toolchain to prefer those tools when rustup components are absent.
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan includes up to 1 review per rolling hour; 0 remain after this review. 📝 WalkthroughWalkthroughCoverage Docker 이미지에 LLVM 도구를 추가합니다. ChangesLLVM coverage 도구 설정
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This localized workflow change is merge-ready after normal checks and review; no actionable merge-blocking risk remains. Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
OpenCode coverage-evidence fails on Rust workspaces (observed on ContextualWisdomLab/TEPP#46 @ 835922c) with:
Root cause: the trusted coverage Docker image installs apt
cargo/rustcand a muslcargo-llvm-covbinary, but not rustupllvm-tools-preview. TEPP (and other repos) already declare the component inrust-toolchain.toml; apt rustc ignores that.Fix
llvmin the coverage tool imagellvm-cov/llvm-profdatainto/usr/local/binLLVM_COV/LLVM_PROFDATAimage envensure_rust_toolchainwhen presentTest plan
Summary by CodeRabbit