fix(automation): yield completed mention repositories fairly - #1165
Conversation
|
@opencode-agent Review only exact current head 941e4bd. This is a bounded fairness fix for the central mention sweep: completed repository futures are observed with as_completed while the four-worker ceiling, rotation, sequential exact-head dispatch, artifact ledger, permissions, and merge authority remain unchanged. Do not self-approve or infer predecessor evidence. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…air-completion-20260820
|
@opencode-agent Review only exact current head 2da6c88. Normal merge from protected main 6479989 has been applied. The bounded as_completed fairness fix remains the only feature diff; the four-worker ceiling, rotation, sequential dispatch, exact-head validation, artifact ledger, permissions, and merge authority are unchanged. Exact local verification at this head: 1,235 tests passed; 7,839 statements and 3,046 branches at 100%; Interrogate touched sweep/router at 100%; compileall and git diff --check passed. Do not self-approve or infer predecessor evidence. Merge requires current-head independent review, terminal required Checks, unresolved-thread clearance, and protected match-head validation. |
|
Current-head review evidence (38aef06): 37 mention-router/sweep/timeout-bound tests pass; changed sweep source and timeout test now have 100% interrogate coverage, Ruff and Python compilation pass, and diff checks are clean. Completion-order observation preserves the four-worker ceiling and bounded shutdown. Independent approval and protected Checks remain required before merge. |
|
@opencode-agent Please review exact current PR head 38aef06. Re-check changed-file scope, current-head findings, unresolved threads, mergeability, and all required checks. Do not approve a stale head. |
Current-head reviewReviewed
No source correction is required from the current diff. Merge remains gated on terminal protected Checks and independent approval. |
|
Current-head review complete at |
Exact-head shared security gate triage
Decision: |
Exact-head restack update
|
Current-head audit — WAIT_AND_REMEDIATE
|
|
Exact-head audit update\n\nObserved hosted failures on the prior head: pip-audit reported PYSEC-2026-3721 through pip 26.1.2; exact-head-path-policy reported stale scheduler assertions. The Strix failure was infrastructure-only: the scan produced no findings but its Caido guest bootstrap could not connect to 127.0.0.1:48080.\n\nRoot-cause fix: refreshed the hash-locked CI dependency to pip 26.2.1 and aligned the scheduler contract assertion with the current repository-dispatch scope.\n\nExact head: 9ebf6d1\nExact base: 6a79f07\nLocal verification: 69 mention-sweep/scheduler tests passed; pip-audit clean; shell syntax and diff checks passed.\nGitHub currently reports the branch behind; required checks and exact-head approval remain pending. Decision remains WAIT_AND_REMEDIATE. |
Current-head verification update
|
|
Exact-head follow-up: pushed |
Summary
The five-minute organization agent-mention sweep already used four repository workers and five-minute rotation, but consumed futures in repository-list order. A slow earlier repository could delay a completed sibling and leave a fresh trusted comment behind the bounded dispatch frontier.
This change:
concurrent.futures.as_completed;CHANGELOG.mdand the existing APA 7 doctoring record.No credentials, model/provider, allowlist, workflow permissions, merge authority, or branch-protection behavior changed.
Verification
uv run coverage erase && uv run coverage run -m pytest tests && uv run coverage report --show-missing --fail-under=100uv run interrogate scripts/ci/agent_mention_router.py scripts/ci/agent_mention_sweep.py --fail-under=100uv run python -m compileall -q scripts/ci/agent_mention_sweep.py tests/test_agent_mention_timeout_bounds.pygit diff --checkThe full repository
interrogate .baseline remains 99.7% because of two pre-existing docstring omissions outside this change. The latest ephemeral Ruff reports three pre-existing issues in the touched sweep file; no new Ruff finding was introduced by this diff.Current exact-head state
Current exact head:
e6838a033a91e7c1a2a22287d5f9922df5a30977.GitHub reports the PR open, ready-for-review, and mergeable. There are no current review submissions.
Fresh exact-head hosted workflows are queued except the repository quality workflows already terminal GREEN:
Earlier local/hosted evidence for predecessor heads does not transfer to this head.
Review and merge boundary
Please review this exact head only. The author must not self-approve. Merge requires a current-head independent review, terminal required Checks, unresolved-thread clearance, and the normal protected merge path with a match-head guard.