fix(noema): paginate large pull request diffs - #1493
Conversation
Use GitHub's paginated pull-request files API so Noema can review ContextualWisdomLab/LineageWeave#640 beyond the 300-file diff endpoint limit. Reconstruct bounded diff context and fail closed when the returned file count does not match the exact PR metadata. Signed-off-by: Seongho Bae <me@seonghobae.me>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
# Conflicts: # scripts/ci/noema_review_gate.py # tests/test_noema_review_gate.py
Signed-off-by: Seongho Bae <me@seonghobae.me>
Signed-off-by: Seongho Bae <me@seonghobae.me>
|
Taking the repair of this PR (not its ownership: it stays a draft; no flip). Reason it matters now: the first post-#1944 Noema evidence artifacts show |
Re-implementation merge: main rewrote the review pipeline (fetch_changed_files with statuses, expected_head re-validation, overlong-line truncation) while this branch replaced the 300-file-limited .diff media request with the paginated Files API. Kept main's pipeline and signatures; ported the paginated reconstruction into fetch_diff; split main's truncation into _bound_diff and apply it only when the reconstructed diff is over-long (the auto-merged chimera would have replaced the last changed line of a short-but-incomplete diff with the overlong marker). GraphQL query keeps both changedFiles and baseRefOid. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
Repaired: Block by block:
Gate on Acceptance once this lands: a Noema run for a >300-file PR (#1555, 321 files) gets past |
Summary
Verification
Unblocks the exact current Noema review path for ContextualWisdomLab/LineageWeave#640 without changing reviewer identity, token selection, verdict, or current-head review submission semantics.