Skip to content

test(strix): restore compatibility entrypoint coverage - #1610

Merged
seonghobae merged 1 commit into
mainfrom
fix/strix-compat-entrypoint-coverage-20260901
Sep 1, 2026
Merged

test(strix): restore compatibility entrypoint coverage#1610
seonghobae merged 1 commit into
mainfrom
fix/strix-compat-entrypoint-coverage-20260901

Conversation

@seonghobae

@seonghobae seonghobae commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Problem

Protected main at c70b081dd93cf9ca53c2277ba95eab0e200cbe5c passes the Strix behavior assertions but no longer satisfies the repository's 100% branch-coverage contract after the GITHUB_ENV publication signature changed. The exact uncovered branches were:

  • scripts/ci/install_strix_timeout_compat.py: lines 92 and 127
  • scripts/ci/strix_timeout_compat.py: line 99

This is a test-only baseline repair required before the independent Noema stabilization PR can receive trustworthy full-suite evidence.

Change

Add regressions for:

  • fail-closed behavior when GITHUB_ENV is absent;
  • the real installer __main__ entrypoint and bound file identities;
  • the real launcher __main__ entrypoint entering patched Strix.

No Strix production code, timeout policy, provider routing, or workflow behavior changes.

Verification

  • RED on exact protected main: missing statements {install_strix_timeout_compat.py: [92, 127], strix_timeout_compat.py: [99]}
  • GREEN after tests: 15 passed
  • both compatibility modules: 100% statement and branch coverage
  • verified again as part of full repository run: 2342 passed, 1 skipped, 21 subtests passed; scripts/ci 100% coverage

Evidence: https://github.com/ContextualWisdomLab/.github/actions/runs/33514831758

Scope

One file, one test-only commit. This PR is deliberately separate from the BandScope/Noema incident repair.


Devin Review

@coderabbitai

coderabbitai Bot commented Sep 1, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 15 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 51d37345-527d-4a15-9371-8ed4b4946e22

📥 Commits

Reviewing files that changed from the base of the PR and between c4f3ba3 and 1e121e0.

📒 Files selected for processing (1)
  • tests/test_strix_llm_timeout_contract.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Restore 100% branch coverage for the protected-main GITHUB_ENV publication change with fail-closed and real-entrypoint regressions. No Strix production code changes.
@seonghobae
seonghobae force-pushed the fix/strix-compat-entrypoint-coverage-20260901 branch from 927a87d to 1e121e0 Compare September 1, 2026 13:50

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

Copy link
Copy Markdown
Contributor Author

QUEUE_SATURATION_CHICKEN_EGG decision for exact head 1e121e0d52c9a277e851d280b2249445f6845894: GitHub reports the PR mechanically mergeable with no conflicts; the diff is one test-only file and changes no Strix production/runtime policy; Devin reports no issues and CodeRabbit/Devin exact-head statuses are success; there are zero review threads; the regression was proven RED on protected main and the same test slice/full-suite evidence reached 100% scripts/ci coverage before extraction into this one-file successor. The exact-head Security Scan, CodeQL, Semgrep, Python Security, OSV, Scorecard, Secret Scan, and SBOM runs are all still queued together under the saturated central Actions fleet. This test-only baseline repair is itself a prerequisite for trustworthy full-suite evidence on the Noema changed-line repair (#1612), so waiting for the saturated lanes creates the circular admission condition this control loop is authorized to break. No failing substantive test/security/review evidence is being bypassed. Merge will be guarded by expected_head_sha.

@seonghobae
seonghobae merged commit a86177e into main Sep 1, 2026
20 of 36 checks passed
@seonghobae
seonghobae deleted the fix/strix-compat-entrypoint-coverage-20260901 branch September 1, 2026 13:57
seonghobae added a commit that referenced this pull request Sep 1, 2026
Construct this reconciliation tree from protected main a86177e, then reapply only PR #1612's four-file semantic delta. Preserve the concurrent exact-head-evidence wake commit 63897f6, #1610's Strix coverage repair, and every unrelated main change. No force push or destructive rebase.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant