fix(actions): let the current-head coalescer finish under push bursts - #1769
Conversation
|
Warning Review limit reachedNext included review available in 26 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| concurrency: | ||
| group: current-head-run-coalescer-${{ github.repository }}-${{ github.event.pull_request.number }} | ||
| cancel-in-progress: true | ||
| # Do not restore cancel-in-progress: true here. This job is the control-plane |
There was a problem hiding this comment.
🔍 Legacy contract matches comment text
An existing contract searches the whole workflow for cancel-in-progress: true. This comment now satisfies it, although the active policy is false.
Was this helpful? React with 👍 or 👎 to provide feedback.
| # Do not restore cancel-in-progress: true here. This job is the control-plane | ||
| # worker that retires redundant runs; cancelling it during a push burst lets | ||
| # the redundant runs survive and worsens the 60-job ceiling. | ||
| cancel-in-progress: false |
There was a problem hiding this comment.
📝 Info: Older workers preserve newer runs
After another push, coalesce rejects the active worker’s stale expected SHA against the live pull request. The pending worker handles the latest head.
Was this helpful? React with 👍 or 👎 to provide feedback.
Conflict in current-head-run-coalescer.yml: main's #1769 (bf28b5d) reintroduced the workflow-level cancel-in-progress: false this branch had already superseded (12d5735) after Devin Review found it only protects a RUNNING job -- GitHub concurrency groups still evict a PENDING (queued) run regardless of cancel-in-progress, which is exactly what queue: max on the job-level concurrency block fixes. Kept this branch's job-level queue: max fix; updated the new main-side regression test (test_current_head_coalescer_self_cancellation.py, added by #1769) to assert queue: max instead of the superseded cancel-in-progress: false, preserving its actual intent (queue, don't kill, the active cleanup worker under push bursts). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…false (#1775) Bypass-merge authorized by the user (2026-09-03, repeated across multiple /loop sessions) for the confirmed chicken-and-egg situation: this PR's own required checks (noema-review, required-workflow-bootstrap, etc.) have sat `queued` for hours under the org's 60-concurrent-job Actions plan ceiling, the exact structural blocker this PR's own fix partially addresses. Content fully independently verified before merge: full suite 2,651 passed, coverage 100%, interrogate 100%, and the fix (queue: max on the coalescer's concurrency group) directly closes a live regression from #1769 that this backlog's own item 13 depends on. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
1 participant
Problem
current-head-run-coalescer.ymlexists to retire redundant queued exact-head runs, but its own concurrency group usedcancel-in-progress: true. A secondsynchronizeevent could therefore cancel the cleanup worker before it cancelled the redundant runs. Under the organization-wide 60-job Actions ceiling, that is self-defeating: the control-plane job is retired while the jobs consuming the queue survive.This is one causal contributor to #712. It does not claim to resolve GitHub-side zero-job
startup_failureorrunner_id=0admission failures.Change
cancel-in-progress: falsecancel-in-progress: trueVerification
mainand not behindMerge policy
This is a central queue-admission/control-plane repair. If its own required workflows cannot start because of the same 60-job ceiling, it is eligible for the narrowly authorized Chicken-and-Eggs bypass, followed immediately by protected-main revalidation. No product or security gate is weakened.
Closes one sub-finding of #712; the remaining
startup_failureand runner-acquisition findings stay open.