fix(tests): sync stale hourly-cron assertion with #1828's daily sweep schedule - #1832
Merged
seonghobae merged 1 commit intoSep 4, 2026
Merged
Conversation
… schedule #1828 ("reduce organization sweep polling") intentionally moved the scheduler's missed-event recovery and org-wide sweep from hourly ("30 * * * *" / "0 * * * *") to daily ("47 3 * * *" / "17 3 * * *"), but left test_reconciled_scheduler_preserves_current_main_control_plane_fixes asserting the old hourly cron -- breaking the required test suite for every .github PR regardless of diff, independently of the #1826/#1823 staleness #1829 just fixed. Reproduced on fresh main (1 failed, 2804 passed) after merging #1829; fixed and reverified (2805 passed, coverage 100%, interrogate 100%). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 48 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
seonghobae
deleted the
fix/queue-cancellation-scheduler-daily-cron-oracle
branch
September 4, 2026 05:28
seonghobae
added a commit
that referenced
this pull request
Sep 4, 2026
…g after merging main Merging origin/main (now including #1832/#1835) surfaced a failure in test_transport_failure_reports_requested_model_and_not_literal_connecting: expected phase=awaiting_response, got phase=response_error. Not a base-branch bug -- ruled out by testing fresh main alone (passes cleanly) and by a peer session's independent clean run. This is a silent merge-combination bug specific to this branch: this branch's own unreleased DNS-pinning/TOCTOU hardening also built a careful connecting-vs-awaiting_response phase distinction (three prior PRs: bebd7c7, e7b29f2, 5c9d30e) via a `reported_phase` ternary gated on `active_phase == "connecting"`. Main's #1831 separately added `active_phase = "response_error"` for the HTTPError case (to also extract served_model from HTTP error bodies) on a non-overlapping line, so the merge produced zero conflict markers -- but by the time this branch's ternary runs, active_phase has already been overwritten, silently defeating the phase distinction for exactly the HTTPError case. Verified "response_error" is not a regression: it is strictly more specific than the old "awaiting_response" fallback (an HTTPError proves a real response arrived, unlike a genuinely ambiguous timeout), and still satisfies the test's real safety property (never mislabel a real HTTP-error response as "connecting"). The two sibling tests covering the non-HTTPError paths are untouched, confirming the fix scope is exactly this one test's stale string expectation, not a deeper production-code issue. Updated the assertion and docstring; no production code change needed. Full verification after fix: 2811 passed, coverage 100%, interrogate 100%. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#1828("reduce organization sweep polling") intentionally moved the scheduler's missed-event recovery and org-wide sweep from hourly ("30 * * * *"/"0 * * * *") to daily ("47 3 * * *"/"17 3 * * *"), but lefttest_reconciled_scheduler_preserves_current_main_control_plane_fixesasserting the old hourly cron string. This broke the required test suite (backendcheck) for every.githubPR regardless of that PR's own diff.Found while investigating [peer 1]'s report that
#1826/#1823each left a stale test assertion (fixed in#1829, already merged). After merging#1829and re-running the suite on freshmain, one additional failure remained — this one, from#1828, a third and independent instance of the same "PR changes behavior, sibling test not updated" class, from the same rapid merge burst.Fix
Updated the assertion to check for the current daily cron values instead of the stale hourly one. The existing regression guard (
assert '*/15 * * * *' not in workflow, preventing a return to the even older quarter-hourly cadence) is unchanged.Verification
main(post-#1829):1 failed, 2804 passed, 1 skipped, 21 subtests passed.2805 passed, 1 skipped, 21 subtests passed.coverage report --fail-under=100: 100%.interrogate: 100%.Developer experience
Restores real signal to the required test suite for every
.githubPR — before this fix, no PR's own required checks could pass regardless of its actual diff.User experience
None (test-infrastructure-only change).
🤖 Generated with Claude Code