Skip to content

test(actions): sync OpenCode concurrency contract - #1848

Merged
seonghobae merged 1 commit into
mainfrom
codex/opencode-concurrency-contract-sync
Sep 4, 2026
Merged

test(actions): sync OpenCode concurrency contract#1848
seonghobae merged 1 commit into
mainfrom
codex/opencode-concurrency-contract-sync

Conversation

@seonghobae

@seonghobae seonghobae commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

변경 사항

  • PR #1845에서 보호 브랜치에 반영된 live-metadata 기반 OpenCode 동시성 그룹을 quick-gate가 그대로 검증하도록 낡은 문자열 기대값 2개를 교체합니다.
  • 구현 변경은 없습니다.

검증

  • bash scripts/ci/test_strix_quick_gate.sh — PASS
  • git diff --check

Actions 계약 테스트 드리프트만 고치는 chicken-and-egg 변경입니다.

Summary by CodeRabbit

  • 개선 사항
    • OpenCode 리뷰 작업의 동시성 그룹이 검증된 PR 정보에 따라 구분되어, 대상 저장소와 PR에 맞게 작업이 관리됩니다.
    • PR 번호를 확인할 수 없는 경우에도 실행 ID를 사용해 작업 간 충돌을 방지합니다.
    • 동시성 그룹 식별 규칙이 일관되게 적용됩니다.

Signed-off-by: Seongho Bae <me@seonghobae.me>
@seonghobae
seonghobae merged commit c129aeb into main Sep 4, 2026
5 of 18 checks passed
@seonghobae
seonghobae deleted the codex/opencode-concurrency-contract-sync branch September 4, 2026 10:47
@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: abc15741-2b5f-4335-a90e-bef272e882a4

📥 Commits

Reviewing files that changed from the base of the PR and between 9c7d28a and cf60efa.

📒 Files selected for processing (1)
  • scripts/ci/test_strix_quick_gate.sh

📝 Walkthrough

Walkthrough

OpenCode 리뷰 동시성 검증이 이벤트 payload 대신 검증된 PR 메타데이터를 사용합니다. PR 번호가 없으면 github.run_id를 사용합니다. 동시성 그룹에 opencode-review- 접두사를 적용합니다.

Changes

OpenCode 리뷰 동시성 검증

Layer / File(s) Summary
검증된 PR 메타데이터 기반 동시성 그룹
scripts/ci/test_strix_quick_gate.sh
동시성 그룹이 validate-pr-metadata의 대상 저장소와 PR 번호를 사용합니다. PR 번호가 없으면 github.run_id를 사용합니다. 기존 head 기반 그룹과 수동 dispatch 전용 fallback 검증을 제거합니다.

Estimated code review effort: 1 (Trivial) | ~5분

Suggested reviewers: claude

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/opencode-concurrency-contract-sync

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

seonghobae pushed a commit that referenced this pull request Sep 6, 2026
Resolves the five-file conflict against protected main (fb2ae81):

- .github/workflows/noema-review.yml and
  tests/test_required_workflow_queue_contract.py: main's side. This branch's
  e09206b keyed the Noema concurrency group on cancelled workflow_run
  events; main has since removed the workflow_run trigger from noema-review
  entirely (Noema reviews PRs standalone; the contract now asserts
  `workflow_run:` is absent), so there is no cancelled-run eviction left to
  isolate and the branch's change has no object. Both files now equal main.
- scripts/ci/test_strix_quick_gate.sh: both sides added
  required_workflow_bootstrap_has_if; kept this branch's exactly-four-space
  '^    if:' (job-level keys only, the CodeRabbit-driven narrowing from
  bc965ea) over main's '^[[:space:]]*if:', and took main's SIGPIPE comment
  and its #1848 concurrency assertions. main's 20 000-line pipe-buffer
  fixture uses a four-space if:, so both of main's own checks still pass.
- tests/test_pr_review_autofix_nvidia_nim_contract.py: REVIEW_DISPATCH_BLOB_SHA
  recomputed from the merged workflow (fc05ee0); neither side's value could
  be right because both sides edit opencode-review-dispatch.yml and git
  auto-merged it.
- CHANGELOG.md: kept both sides' [Unreleased] bullets.

The branch's delta against main is now exactly its stated scope: the
npm_lock_project_dir ancestor-lock search in opencode-review-dispatch.yml,
its contract tests, the quick-gate regex, the blob pin and one CHANGELOG
bullet. Touched contracts: 184 passed, 1 skipped.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01KPmJErfkcHer4UVEgrQxUX
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant