fix(actions): reduce scheduled recovery pressure - #1860
Merged
Conversation
Signed-off-by: Seongho Bae <me@seonghobae.me>
|
Warning Review limit reachedNext included review available in 9 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
seonghobae
added a commit
that referenced
this pull request
Sep 4, 2026
Full-suite run after the first commit surfaced two more casualties of the same class of issue: - test_github_hourly_conflict_repair.py::test_central_repository_has_hourly_self_caller asserted the same stale hourly cron format (#1860) for the .github self-caller entry that the first commit already fixed for the other 17 hourly-review-repair.yml targets; missed because it lives in a different test module than test_hourly_review_repair_callers.py. - test_docs_only_pr_runner_admission.py's changed-scope byte-identity check only stripped lines literally starting with "if:", so it never handled a YAML block-scalar `if: >-` condition split across multiple lines. #1869 gave strix.yml's changed-scope job exactly that (a multi-line if: adding a converted_to_draft skip, intentionally scoped to Strix/Noema per that PR's own description and not needed by security-scan.yml/sast-semgrep.yml's unrelated SAST/dependency jobs), which the test's own normalization couldn't see past -- flagging a real difference in the job body that does not exist. Made the normalization indentation-aware so it skips the entire if: block (its continuation lines included), not just its first line. python3 -m pytest tests/test_github_hourly_conflict_repair.py tests/test_docs_only_pr_runner_admission.py -q -- 14 passed. Full coverage run -m pytest tests now at 2851 passed, 1 skipped, 21 subtests passed, 0 failed. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2 tasks
seonghobae
added a commit
that referenced
this pull request
Sep 4, 2026
…ions): preserve hourly review recovery cadence" This reverts commits 25083c8 and 8340e40. Both commits reverted hourly-review-repair.yml's daily-staggered cron cadence (17 targets spread across distinct hour+minute slots, e.g. "2 0 * * *") back to the old, deliberately-retired hourly format (e.g. "2 * * * *"), and updated their test oracles to match -- directly undoing #1860's ("reduce scheduled recovery pressure") intentional fix for the shared 60-job Actions concurrency ceiling. The daily-staggered cadence is still current main's actual, correct production behavior (confirmed by diffing origin/main directly), and this PR's own body already documented "daily-staggered is already-landed, already-correct production behavior... to cut Actions congestion" -- these two commits directly contradicted that, with no investigation notes or rationale in either commit message. Caught by peer1 before this branch left Draft. Neither commit originated from this session's own work on this branch. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Evidence
Hourly Review Repairruns at the same protected-main headScope
Actions-only. No release/build/deploy/publish/package/image/migration behavior is changed.
Signed-off-by: Seongho Bae seonghobae@users.noreply.github.com