docs(item4): confirm the served_model/phase telemetry fix landed and works - #1868
Merged
Conversation
…works The .github-side follow-up this entry named as still-needed (call_llm not reading the HTTPError response body, so it couldn't surface served_model) shipped in #1831 (merged), hardened by #1835 and #1850. Found incidentally while handling an unrelated Autofix event on PR #1757: a fresh gateway failure now logs phase=response_error and a real model name (served_model=google/gemma-4-31b-it) instead of the old unknown/connecting pair. The underlying gateway instability (502 after 284.7s) is still a separate, open, recurring problem -- but the telemetry gap that made every prior instance of it undiagnosable is closed. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 49 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughHTTP 오류 텔레메트리의 단계 분류와 모델 귀속 결과를 기준선 문서에 추가했다. 운영 로그에서 ChangesHTTP 오류 텔레메트리 기준선
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This updates the technical baseline with HTTP error telemetry behavior and validation results. No current merge-blocking risk remains. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
seonghobae
enabled auto-merge (squash)
September 5, 2026 02:27
seonghobae
pushed a commit
that referenced
this pull request
Sep 5, 2026
…grity rules Both contributed by a reviewing session from measurements it made today, not by this session. Recorded here because the catalog is the org's shared store and a lesson only pays off when someone other than its author can find it. Signature 8 -- same-anchor merge conflicts. The collision unit for append-heavy documents is the anchor, not the file. Measured on docs/product-technical-gap-baseline.md: #1868 merged SECOND into the same file and stayed clean because its hunk sat in a different region, while #1903 broke on sharing #1868's anchor. So a path-level claim is wrong in both directions -- it over-serializes PRs that would never have touched and fails to warn the pair that actually conflicts. Also records that `behind` is admin-mergeable with zero pushes while `dirty` is a git-level conflict that cannot be bypassed (405), so the push-free path exists for exactly one PR per anchor per round. Measurement integrity, under the KPI table. `c=$(gh api ... || echo 0)` turns a rate-limited call into a genuine-looking zero; in a real sweep that produced impossible rows (in_progress_runs=13 with running_jobs=0 AND queued_jobs=0) which were briefly explained away as "the metric oscillates" rather than read as the instrument breaking. Re-measured without the mask: min 27 / max 36 / mean 32.1, stable. Three rules follow: never let a failed call fall back to a countable value, treat a self-contradictory row as the tell, and settle a disagreement about a total by printing records rather than recounting. Every KPI in this file is a script-produced count, so these belong beside the table rather than in a separate note. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BV96rXhqoR3tYZ9AeAVur4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Item 4's gap-baseline entry named a still-needed fix:
scripts/ci/noema_review_gate.py'scall_llmcaughturllib.error.HTTPErrorwithout reading the response body, so it couldn't surface the gateway'sserved_model/error detail. That fix shipped:#1831("ground verdicts and classify gateway errors," merged), hardened by#1835and#1850.Found incidentally while handling an unrelated Autofix event on PR #1757: a fresh gateway failure now logs
phase=response_errorand a real model name (served_model=google/gemma-4-31b-it) instead of the oldunknown/generic-phase pair. The underlying gateway instability (502 after 284.7s) is still a separate, open, recurring problem — but the telemetry gap that made every prior instance of it undiagnosable is closed.Test plan
python3 -m pytest tests/test_product_technical_gap_baseline.py -q— 5 passed🤖 Generated with Claude Code
Summary by CodeRabbit