fix(tests): resync opencode-review-dispatch.yml blob-pin after #1892 - #1894
Merged
Conversation
#1892 ("bound opencode model runtime to 900 seconds") added a timeout-minutes line to opencode-review-dispatch.yml, changing its git blob hash, but didn't update the byte-for-byte pin this contract test (and its paired test_opencode_rust_coverage_toolchain_contract.py cross- reference) asserts -- breaking the required coverage/test gate for every PR in this repository. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 2 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
seonghobae
added a commit
that referenced
this pull request
Sep 5, 2026
… fix (#1894) Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
seonghobae
added a commit
that referenced
this pull request
Sep 5, 2026
…s revert (#1897) #1895 reverted #1892's timeout-minutes addition to opencode-review-dispatch.yml, restoring its blob hash to ade10b3 -- but did not restore the pin this contract test asserts (which #1894 had correctly updated to match #1892's now-reverted state), breaking the required test gate for every open PR in this repository again. Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
seonghobae
added a commit
that referenced
this pull request
Sep 5, 2026
…s revert #1895 reverted #1889/#1892's model-inference wall-clock caps, restoring opencode-review-dispatch.yml's pre-#1892 content. That content change left REVIEW_DISPATCH_BLOB_SHA in test_pr_review_autofix_nvidia_nim_contract.py pinned to the intermediate #1894 resync value (fca5bfc...), not the now-current content (recomputed directly via git hash-object rather than reasoned from history: ade10b3). Same-day stale-pin pattern already seen this session (#1810, #1874) -- a workflow content change updates most-but-not-all of the tests asserting the old content's exact hash. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#1892("bound opencode model runtime to 900 seconds") added atimeout-minutesline to.github/workflows/opencode-review-dispatch.yml, changing its git blob hash fromade10b37c43d0f2b46490b2196c893244afc3d49tofca5bfc9079f3d2b141da715a796a96933ae547f, but did not updatetests/test_pr_review_autofix_nvidia_nim_contract.py'sREVIEW_DISPATCH_BLOB_SHAbyte-for-byte pin.tests/test_opencode_rust_coverage_toolchain_contract.pycross-references the same constant via regex, so updating it in one place fixes both failing tests.Test plan
python3 -m pytest tests/test_pr_review_autofix_nvidia_nim_contract.py tests/test_opencode_rust_coverage_toolchain_contract.py -q— 31 passed, 1 skippedcoverage run -m pytest tests -q— 2841 passed, 1 skipped, 21 subtests passedgit hash-object .github/workflows/opencode-review-dispatch.ymlmatches the new pinned constant exactlyNote: this branch's own
coverage report --fail-under=100still shows the pre-existing, separately-tracked admission-controller coverage/docstring gap (review_admission_controller.py,pr_review_merge_scheduler_core.py,audit_codeql_default_setup_rollout.py) — already fixed and pending merge via.github#1883, unrelated to this PR's scope.🤖 Generated with Claude Code