Skip to content

fix(scheduler): reject draft merge mutations - #2006

Draft
seonghobae wants to merge 2 commits into
fix/scheduler-skip-central-target-inventoryfrom
fix/scheduler-draft-merge-mutation-guard
Draft

fix(scheduler): reject draft merge mutations#2006
seonghobae wants to merge 2 commits into
fix/scheduler-skip-central-target-inventoryfrom
fix/scheduler-draft-merge-mutation-guard

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

Root cause

Scheduler inspection filters Draft pull requests, but the irreversible enable_auto_merge and merge_pr entrypoints did not revalidate lifecycle state. A stale Ready decision or direct caller could therefore reach a merge mutation after the PR became Draft.

This bounded successor carries the corresponding valid delta from historical Draft #1231 and is stacked after #2005.

RED → GREEN

  • RED: 2d140a84203a0df0cb86cd6b6ab31fc37bbdbda2
    • requires both mutation functions to reject Draft before executing a GitHub command
  • GREEN: 5abc0a0284bcf2ee11715e642f882af73f1e8adb
    • adds one lifecycle guard to each mutation entrypoint
    • preserves the existing expected-head and actor guards for non-Draft PRs
    • updates CHANGELOG, APA-style doctoring, and docs/product-technical-gap-baseline.md

Stack and authority

  • Base: fix/scheduler-skip-central-target-inventory@a42ab0035b953241ad81f01414efad555287540c
  • Normal fast-forward commits only; no force push or rebase
  • No review, status, ruleset, or merge protection is weakened
  • Status remains Proposed pending parent integration and fresh exact-head evidence

@coderabbitai

coderabbitai Bot commented Sep 7, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae seonghobae added bug Something isn't working type: bug Defect or incorrect behavior priority: medium Normal-priority or P2 work labels Sep 7, 2026 — with ChatGPT Codex Connector
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working priority: medium Normal-priority or P2 work type: bug Defect or incorrect behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant