Skip to content

fix(opencode): make GPU adapter selection deterministic - #2031

Draft
seonghobae wants to merge 5 commits into
mainfrom
fix/opencode-rust-gpu-adapter-glob-order
Draft

fix(opencode): make GPU adapter selection deterministic#2031
seonghobae wants to merge 5 commits into
mainfrom
fix/opencode-rust-gpu-adapter-glob-order

Conversation

@seonghobae

@seonghobae seonghobae commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Goal

Carry the still-valid Rust GPGPU adapter-selection responsibility out of historical #1231 as one bounded canonical-owner change.

RED → GREEN

  • RED 4d976e8899e755f4e9c2caca804278ae304b3611: requires deterministic pathname selection and rejects the ls | head pipeline.
  • Implementation fd2a497f3484cdd1938fd07beffaa6a7cf40a09a: sets function-local LC_ALL=C, iterates the trusted lavapipe manifest glob, selects the first regular file, and preserves the existing no-adapter path.

Boundary

This PR changes only the OpenCode Rust coverage software-adapter discovery contract. It does not claim carryover of #1231's SBOM, scheduler, NVIDIA, or sweep responsibilities and does not move Rust/GPU ownership into Python.

Documentation

Updates CHANGELOG, APA-style doctoring, and docs/product-technical-gap-baseline.md. Status is Proposed until exact-head hosted Checks and independent review are terminal. Runtime Quality run 34181647719 verified the full repository (2985 passed, 1 skipped, 21 subtests, 100% coverage) but failed git diff --check because two modified files retained an extra EOF blank line. Commit d34e18688aab17ef210584ebc6ad62c417e8412f normalizes only those two endings; its fresh hosted Checks are the current authority.

Safety

The branch is a normal four-commit descendant of protected main@78a4937c684a54ca8e415822c913742f41c6efc4. No force push, rebase, provider/model change, gate weakening, or evidence transfer was used.

Refs #1231.

@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Contributor Author

Exact-head publication receipt: main@78a4937c684a54ca8e415822c913742f41c6efc4 → RED@4d976e8899e755f4e9c2caca804278ae304b3611 → implementation@fd2a497f3484cdd1938fd07beffaa6a7cf40a09a; compare 2 ahead / 0 behind, five files, mergeable, Draft/Proposed, zero review threads. All five hosted workflows were created for the implementation head and remain queued. No predecessor or sibling status is authoritative.

Copy link
Copy Markdown
Contributor Author

Exact-head Runtime Quality RCA and direct repair:

  • predecessor head: fd2a497f3484cdd1938fd07beffaa6a7cf40a09a
  • run/job: 34180697875 / 101919047830
  • failure 1: new regression referenced undefined OPENCODE_DISPATCH; repaired to the existing canonical _DISPATCH_WORKFLOW_PATH
  • failure 2: independent trusted-workflow blob pin remained d86497b3f43bebbabbb4f504eb5132cdf3b7b293; exact changed workflow hashes to bbbdf45c5fbb312ead7c99023a86d78a287d10dd
  • repaired head: 4bea311ec38f60ceb224511add0af1b53a452dfd

Production workflow behavior is unchanged by this correction. The update is a normal fast-forward descendant; no force update, bypass, or predecessor Check transfer. Fresh exact-head Checks are authoritative.

Copy link
Copy Markdown
Contributor Author

Exact-head RCA for 4bea311ec38f60ceb224511add0af1b53a452dfd: Runtime Quality run 34181647719, job 101921773827, completed the focused GPU contract, scheduler contracts, full repository (2985 passed, 1 skipped, 21 subtests) and 100% coverage. The sole gate failure was git diff --check: docs/product-technical-gap-baseline.md:3364 and tests/test_opencode_rust_coverage_toolchain_contract.py:231 each had one extra EOF blank line. Commit d34e18688aab17ef210584ebc6ad62c417e8412f is a normal child and changes only those two file endings. Fresh checks for that exact head are required; the predecessor GREEN portions are not transferred.

@seonghobae seonghobae added bug Something isn't working priority: high High-priority or P1 work type: bug Defect or incorrect behavior labels Sep 8, 2026 — with ChatGPT Codex Connector

Copy link
Copy Markdown
Contributor Author

Restack onto protected main@7fd571dbcdbae6acf29d8f4ee704d7ba6297e4db with non-force git merge --no-ff origin/main.

  • previous head d34e18688aab17ef210584ebc6ad62c417e8412f remains an ancestor
  • new head 17e0b3fa34f47f8c40304c83165a92cd1ad0df74
  • conflicts: none
  • focused: tests/test_opencode_rust_coverage_toolchain_contract.py + tests/test_pr_review_autofix_nvidia_nim_contract.py → 32 passed, 1 skipped

Left Draft. Fresh exact-head checks required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working priority: high High-priority or P1 work type: bug Defect or incorrect behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant