Skip to content

fix(noema): close document reader review gaps - #2178

Merged
seonghobae merged 1 commit into
mainfrom
codex/noema-document-review-followup-20260914
Sep 13, 2026
Merged

fix(noema): close document reader review gaps#2178
seonghobae merged 1 commit into
mainfrom
codex/noema-document-review-followup-20260914

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

Follow-up to #2172 (merged at 04d0f65).

Fixes the post-merge review findings on the canonical Noema document reader:

  • normalize defusedxml entity exceptions to bounded DocumentReadError
  • anchor hwp-mcp error sentinels so valid body text is not rejected
  • select all document-reader files and run document-context tests in runtime-quality CI

Validation: real simple.hwp and text_only.hwpx fixtures reach the captured reviewer payload; entity and malformed DOCX cases fail closed; local owner tests, Bandit, Semgrep, gitleaks diff, pip-audit, actionlint, and syntax checks pass. No private manuscript or participant content is included.

@coderabbitai

coderabbitai Bot commented Sep 13, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 24 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 377dbea4-f482-4354-8a6e-972185a6bea3

📥 Commits

Reviewing files that changed from the base of the PR and between 04d0f65 and 25eaa9f.

📒 Files selected for processing (4)
  • .github/workflows/agent-review-runtime-quality-ci.yml
  • scripts/ci/noema_hwp_mcp_reader.mjs
  • scripts/ci/noema_review_document.py
  • tests/test_noema_document_review_context.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae
seonghobae merged commit 828eaae into main Sep 13, 2026
6 of 16 checks passed
@seonghobae
seonghobae deleted the codex/noema-document-review-followup-20260914 branch September 13, 2026 17:57
seonghobae added a commit that referenced this pull request Sep 13, 2026
Ordinary non-force restack for #2079 through protected #2172/#2178 Noema document-reader advances. Preserve both histories; exact-head acceptance restarts before the owner-local fixture-docstring repair.
seonghobae added a commit that referenced this pull request Sep 13, 2026
Ordinary non-force restack for #2170 after #2178. Preserve both histories; exact-head acceptance restarts.
seonghobae added a commit that referenced this pull request Sep 13, 2026
Ordinary non-force restack for #2106 after #2178. Preserve both histories; exact-head acceptance restarts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant