Skip to content

fix(review): 사주 CalDAV 오프라인 Python 의존성 추가#594

Open
seonghobae wants to merge 3 commits into
mainfrom
agent/saju-caldav-offline-deps
Open

fix(review): 사주 CalDAV 오프라인 Python 의존성 추가#594
seonghobae wants to merge 3 commits into
mainfrom
agent/saju-caldav-offline-deps

Conversation

@seonghobae

@seonghobae seonghobae commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

자동 리뷰 증거 계약

  • adversarial_validation의 각 probe는 구조화된 path와 양의 line, evidence의 정확한 path:line을 서로 같게 작성해야 합니다.
  • source-line-sha256 receipt는 그 동일한 current-head 줄에 결합되어야 합니다.

요약

  • OpenCode coverage-evidence의 신뢰된 기본 브랜치 이미지에 사주 CalDAV 테스트용 wheel 의존성 5개를 정확한 버전과 해시로 추가합니다.
  • bcrypt, FastAPI, HTTPX, iCalendar, 한국 음력 변환의 전이 의존성을 포함해 총 34개 패키지를 --require-hashes 및 --only-binary 계약으로 설치합니다.
  • lunar-python 1.4.8은 공식 배포가 sdist뿐이어서 중앙 네트워크 격리 이미지에 넣지 않고, 대상 저장소가 검증한 소스를 MIT 고지와 함께 벤더링합니다.
  • PR 제어 requirements는 계속 실행하지 않으며 coverage 실행 단계는 --network=none을 유지합니다.

실패 근거

  • 기존 OpenCode run 29685953768의 coverage-evidence job 88190132868은 대상 테스트 수집 중 fastapi, korean_lunar_calendar, icalendar, bcrypt, lunar_python import 누락만으로 실패했습니다.

검증

  • 중앙 저장소: 635 passed
  • 새 잠금 계약 테스트: 1 passed, Ruff 통과
  • 중앙 Dockerfile과 새 해시 잠금으로 Linux 이미지 빌드 성공
  • 최신 대상 헤드 96fa833을 --network=none 격리 컨테이너에서 실행: 41 passed
  • 대상 CI test, container, CodeQL, Semgrep, OSV, Trivy, Strix 모두 성공

Closes #593
Unblocks ContextualWisdomLab/saju-caldav#6

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the trusted, offline OpenCode coverage-evidence Python environment by adding a hash-pinned runtime dependency set needed to run ContextualWisdomLab/saju-caldav tests in a --network=none sandbox, while keeping the existing “install from trusted lock only” discipline.

Changes:

  • Added a new contract test to ensure the newly trusted saju-caldav runtime dependencies are present as exact pins in the source requirements and are hash-locked in the generated lock file.
  • Appended the required runtime dependency pins (bcrypt/FastAPI/HTTPX/iCalendar/korean-lunar-calendar) to requirements-opencode-review-ci.txt.
  • Regenerated requirements-opencode-review-ci-hashes.txt with uv to include hashes for the expanded dependency closure.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
tests/test_opencode_python_dependency_lock.py Adds a contract test enforcing that specific saju-caldav runtime pins are present and hash-locked (and that lunar-python is not).
requirements-opencode-review-ci.txt Adds the trusted runtime pins required for offline saju-caldav test collection/execution.
requirements-opencode-review-ci-hashes.txt Regenerated uv lock with hashes for the expanded trusted dependency set.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tests/test_opencode_python_dependency_lock.py Outdated
@opencode-agent
opencode-agent Bot disabled auto-merge July 20, 2026 13:27
@seonghobae
seonghobae enabled auto-merge (squash) July 20, 2026 21:20
@opencode-agent
opencode-agent Bot disabled auto-merge July 21, 2026 00:13
@seonghobae
seonghobae enabled auto-merge (squash) July 21, 2026 05:41
@opencode-agent
opencode-agent Bot disabled auto-merge July 21, 2026 05:41
Copilot AI review requested due to automatic review settings July 21, 2026 10:56

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

Comment thread tests/test_opencode_python_dependency_lock.py Outdated
Copilot AI review requested due to automatic review settings July 21, 2026 11:10

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

fix(review): 사주 CalDAV의 오프라인 Python 증거 의존성 추가

2 participants