-
Notifications
You must be signed in to change notification settings - Fork 0
hotfix: Prefer NVIDIA NIM models in OpenCode review pool #680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| # NVIDIA NIM OpenCode model priority (hotfix) | ||
|
|
||
| ## Why | ||
|
|
||
| OpenCode Agent failed to produce a usable review on the PR thread starting at | ||
| ContextualWisdomLab/fast-mlsirm#290 (`opencode-review` check **skipped**, no | ||
| `opencode-agent[bot]` review comment). Central review therefore prioritizes | ||
| **NVIDIA NIM** models as additional catalog candidates so the model pool can | ||
| still emit APPROVE / REQUEST_CHANGES when GitHub Models / free tiers stall. | ||
|
|
||
| ## Changes | ||
|
|
||
| 1. `opencode.jsonc` | ||
| - `enabled_providers`: `nvidia-nim` first, then `github-models` | ||
| - default `model` / `small_model` prefer NIM Nemotron / Llama 3.3 | ||
| - new OpenAI-compatible provider `nvidia-nim` → `https://integrate.api.nvidia.com/v1` | ||
| with `apiKey: {env:NVIDIA_API_KEY}` | ||
| 2. `.github/workflows/opencode-review-dispatch.yml` | ||
| - `OPENCODE_MODEL_CANDIDATES` prefixes six NIM models before existing pool | ||
| - binds `NVIDIA_API_KEY: ${{ secrets.NVIDIA_API_KEY }}` | ||
| 3. `scripts/ci/run_opencode_review_model_pool.sh` | ||
| - skips `nvidia-nim/*` when `NVIDIA_API_KEY` is unset (same pattern as OpenRouter) | ||
|
|
||
| ## Temporary permission bypass (hotfix only) | ||
|
|
||
| For this merge-aid hotfix only: | ||
|
|
||
| - Branch-protection / ruleset admin override may be used to land the central | ||
| `.github` change if required checks conflict during the hotfix window. | ||
| - **Do not** permanently weaken Security Scan, trivy-fs, osv-scan, or | ||
| CodeQL gates. | ||
| - **Do not** flip OpenCode agent `permission.edit` / `bash` from `deny` to | ||
| `allow` permanently; review agents remain read-only. | ||
| - Org secret `NVIDIA_API_KEY` must be set on ContextualWisdomLab for NIM pool | ||
| entries to execute; without it the pool falls through to prior candidates. | ||
|
|
||
| ## Rollback | ||
|
|
||
| Remove the `nvidia-nim/*` prefixes from `OPENCODE_MODEL_CANDIDATES`, drop the | ||
| `nvidia-nim` provider block, and delete this note once GitHub Models / OpenCode | ||
| catalog reliability is restored. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.