feat(opencode): add head-matched gold corpus tooling - #831
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
@opencode-agent @cwl-noema-review Review-only request for exact stacked head Inspect the complete 13-file diff, deterministic sampling algorithm, strict JSON boundaries, blinding and independence contracts, exhaustive finding coverage, accepted/rejected decision separation, immutable receipts, CLI failure classes, exact-head CI, APA 7th doctoring, and the explicit empty-real-corpus/parity claim boundary. Distinguish substantive source defects from the intentional absence of fabricated annotations and from stacked-base merge readiness. Do not modify the branch, update or retarget the base, create expert judgments, reveal automated reviewer outputs to the gold process, approve on behalf of an author, merge, release, weaken tests, alter reviewer credentials/model policy, or reuse predecessor-head evidence. |
Purpose
Implement Task 4 of the OpenCode review-quality program: deterministic exact-head sampling and blinded two-expert-plus-adjudicator freezing for a real expert-gold corpus.
Exact stacked identity
feat/opencode-review-quality-gate(PR feat(opencode): add empirical review-quality gate #829);523e883b9088d1ac7edad3f3f60eb6ebdb0948a7;feat/opencode-review-gold-corpus;ad71f1fddefbbca5be3d94d90434a6c172188d96;2d3100b27d1d979e6e2f3ead2fc278b08a840b44;No check, review, approval, or comment from PR #829 authorizes this stacked head. If #829 moves or merges, this branch must be reconciled once onto the integrated protected base and every exact-head evidence surface regenerated.
Test-first evidence
The initial exact RED run
31257290890checked outad71f1fddefbbca5be3d94d90434a6c172188d96and failed during test collection because the two production modules intentionally did not exist. That result proves the permanent contracts preceded implementation; it is not acceptance evidence for the current head.The implementation then added strict offline corpus tooling, split the adjudication boundary into focused modules, and added only coverage regressions required by the permanent 100% gate. No test was deleted, weakened, skipped, or converted into an expected failure.
Implemented sampling contract
Implemented blinded gold contract
The tools do not create expert judgments. Live acquisition, expert review, and reviewer-output capture remain separately authorized human/trusted-collector boundaries. The committed
head_matched_v1directory explicitly remainsEMPTY_PENDING_REAL_COLLECTION; no fabricated case or parity claim is included.Exact-current-head verification
OpenCode Review Corpus Quality CI run
31259176993checked out exact head2d3100b27d1d979e6e2f3ead2fc278b08a840b44and completed successfully:55 passed;487/487;170/170;100%;Per-module evidence:
opencode_review_sample.py: 212 statements, 68 branches, 100%;opencode_review_adjudicate.py: 91 statements, 26 branches, 100%;The doctoring protocol records blinding, role separation, exact-head collection, sampling, adjudication, partition leakage prevention, reviewer capture after gold freeze, privacy/security, quality controls, limitations, and APA 7th research traceability.
CHANGELOG.mdrecords the bounded capability.Safety and acceptance
COPILOT_GITHUB_TOKENuse;Keep Draft and do not merge until PR #829 reaches protected
main, this branch is reconciled onto that exact protected base, the complete organization CI/security/review suite reruns on the resulting exact head, no valid unresolved finding remains, and a qualifying independent non-author formal approval exists. Pending, skipped-required, status-only, author-only, stale-head, predecessor-head, synthetic-merge, rate-limited, or absent evidence is not acceptance.