Skip to content

fix: neutralize Strix fail-closed after provider infrastructure - #957

Closed
seonghobae wants to merge 1 commit into
mainfrom
fix/strix-neutralize-fail-closed-after-provider-infra
Closed

fix: neutralize Strix fail-closed after provider infrastructure#957
seonghobae wants to merge 1 commit into
mainfrom
fix/strix-neutralize-fail-closed-after-provider-infra

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

Why

Open contextual-orchestrator PRs fail required Strix after NVIDIA NIM nemotron-3-super-120b-a12b exits 2 (~4778s). The gate prints:

Strix scan failed after provider infrastructure or failure-signal output; failing closed.

The outer workflow already treats provider infrastructure as a neutral skip when there is no vulnerability signal, but its regex only listed the sibling wording emitted provider infrastructure or failure-signal output. The required-CI line therefore failed closed as a "non-backend reason."

Change

  • Add failed after provider infrastructure or failure-signal output to backend_unavailable_signal in .github/workflows/strix.yml.
  • Add a unit test that feeds the exact required-CI fail-closed lines and asserts neutralization, while existing tests still refuse reported vulnerabilities.

Verification

python3 -m unittest tests.test_strix_nvidia_nim_not_found_fallback -v — 12 passed.

This does not weaken severity gating. A log that also contains Vulnerabilities 1+ still fails.

Required CI prints "scan failed after provider infrastructure" when
NVIDIA NIM exits 2. The outer gate only recognized the "emitted"
wording, so those scans stayed blocking. Match the actual line and
keep real vulnerability signals blocking.
@seonghobae
seonghobae enabled auto-merge (squash) August 13, 2026 06:05
@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 36 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 2829ee99-6e45-4c4a-bc7b-c51be1fc976d

📥 Commits

Reviewing files that changed from the base of the PR and between 6eb06cd and db32764.

📒 Files selected for processing (2)
  • .github/workflows/strix.yml
  • tests/test_strix_nvidia_nim_not_found_fallback.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

seonghobae added a commit that referenced this pull request Aug 13, 2026
The gate prints "failed after provider infrastructure or failure-signal
output" after NVIDIA NIM exit 2. The outer regex only listed the sibling
"emitted ..." wording, so required CI treated that line as a non-backend
fail. Fold #957 into this neutralization.
@seonghobae

Copy link
Copy Markdown
Contributor Author

Incorporated into #956 (failed after provider infrastructure or failure-signal output plus the leftover-TUI incomplete-evidence override). Closing this slice so one neutralization lands.

@seonghobae

Copy link
Copy Markdown
Contributor Author

Superseded by #956, which now includes this fail-closed wording.

@seonghobae seonghobae closed this Aug 13, 2026
auto-merge was automatically disabled August 13, 2026 06:11

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant