feat(reports): preserve grouping-comparison graphic delta for serialized successor - #841
Conversation
…61.0) Draw the leftover-map graphic display of persisted ξ / ζ above grouping comparison leftover-pair buttons when four leftover-map axes are finite (ADR 0304).
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Cycle overlay 2026-08-31 03:39 KST. Writes work. Do not self-approve. Do not squash-merge.
Independent approval is required. No self-approval, admin bypass, or force push. |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| <LeftoverMapPlot | ||
| pairs={row.leftover_pairs} | ||
| criterionLabel={criterionShortLabel} | ||
| onSelectPost={(pair) => { | ||
| onSelectPost(pair.post_id, { | ||
| fromLeftoverPair: { | ||
| pairKind: pair.pair_kind === "farthest" ? "farthest" : "closest", | ||
| criterionCode: pair.criterion_code, | ||
| }, | ||
| }); | ||
| }} | ||
| /> |
There was a problem hiding this comment.
📝 Info: Marker clicks preserve criterion focus
Each marker resolves to a plottable authorized pair. Its kind and criterion reach onSelectPost, preserving the pair-button landing behavior.
Was this helpful? React with 👍 or 👎 to provide feedback.
| <LeftoverMapPlot | ||
| pairs={row.leftover_pairs} | ||
| criterionLabel={criterionShortLabel} | ||
| onSelectPost={(pair) => { | ||
| onSelectPost(pair.post_id, { | ||
| fromLeftoverPair: { | ||
| pairKind: pair.pair_kind === "farthest" ? "farthest" : "closest", | ||
| criterionCode: pair.criterion_code, | ||
| }, | ||
| }); | ||
| }} | ||
| /> |
There was a problem hiding this comment.
📝 Info: Comparison metadata remains separate
The reused plot receives neither axis shares nor coverage. It keeps generic axes while existing validated comparison notes remain outside the figure.
Was this helpful? React with 👍 or 👎 to provide feedback.
seonghobae
left a comment
seonghobae
left a comment
There was a problem hiding this comment.
Current-head governance finding paired with #842 review 5123590911: this Draft branch owns the grouping-comparison graphic decision at ADR 0304 on exact parent #840 b5732ba2a6de25595989db0b5fb74308b8eae75a, but docs/adr/0304-leftover-map-compare-graphic.md is marked Accepted without qualifying independent current-head approval. Sibling #842 on the same exact parent independently reused ADR 0304/v2.61.0 for axis-share disclosure. Preserve this branch's valid graphic delta and ADR 0304 identity, but return the ADR to Proposed until an unchanged release-ready head is independently approved. #842 is the branch that should move its distinct axis-share decision to verified-unclaimed ADR 0368; do not collapse the two decisions. The shared v2.61.0 release-number collision remains explicit until normal integration ordering or verified successor inheritance resolves it.
seonghobae
left a comment
seonghobae
left a comment
There was a problem hiding this comment.
Exact-head Tests run 34004916439 is a real source RED, not a queue/control-plane failure. Three causal defects are current: (1) the grouping-graphic branch dropped the previously reviewed small-canvas caption-bounds repair, so the 20px regression gets labelY=-20; (2) Vietnamese explained-share production copy regressed to phần dư giải thích..., and its regression test also duplicates the pre-coverage English caption instead of importing LEFTOVER_MAP_PLOT_CAPTION; (3) runtime provenance still reports lineageweave.__version__ = 2.41.0 while pyproject/frontend ship 2.61.0. The full Python run otherwise reached 1766 passed / 147 skipped before the version invariant failed. Repair must preserve ADR 0304 Proposed and the grouping-graphic delta, carry the known caption-bounds algorithm forward, restore the two Vietnamese share strings, bind the Vietnamese regression to the production caption constant, and synchronize runtime version to 2.61.0. No gate weakening or predecessor-check transfer.
seonghobae
left a comment
seonghobae
left a comment
There was a problem hiding this comment.
Foundation correction: the small-canvas/Vietnamese/runtime drift reproduced here is already present on direct parent #840 (b5732ba2a6de25595989db0b5fb74308b8eae75a). The existing child-local r2 lane 34012511589 is therefore not the canonical promotion path even after repair. A new #840 exact-head lane owns the shared patch; keep ADR 0304/v2.61.0 delta intact, then reconstruct #841 non-force from the repaired #840 and synchronize runtime identity to 2.61.0. Do not promote the sibling-local patch as an independent source fork.
seonghobae
added
enhancement
ChatGPT Codex Connector
seonghobae
changed the title
1 participant
Summary
Preserve the valid grouping-comparison graphic-composition delta: draw the existing
LeftoverMapPlotfrom persisted finiteξ/ζabove comparison pair buttons. No new SQL/schema, invented coordinates/scores/theta, or persisted inner-product/cosine/length.Current stack authority
GitHub base metadata points to immediate predecessor #840 (
feat/leftover-map-compare-coordinates-payload-v2600@b5732ba2a6de25595989db0b5fb74308b8eae75a). #840 now records the repaired authority: exact #827 is current, #828 is the earliest active reconstruction, and #829→#840 preserve valid downstream deltas. The previous #841 description naming #820 as earliest stale is superseded.Historical v2.61.0 and product head
87979568b36219ae99631e88f32d0af1a9247923are evidence only. ADR0304 remains Proposed; reconstruct this graphic delta only after exact promoted #840 and allocate a coherent then-unclaimed release identity. Sibling #842 owns a distinct axis-share decision and must remain separate rather than collapsing historical duplicate release numbers.Descendants that contain this provisional head must be reconstructed after #841 moves; predecessor checks/approval do not transfer.
Product invariants
Render the existing graphic only for pairs with four finite persisted coordinates. Missing/non-finite coordinates omit the pair rather than inventing a location; stored origin
(0, 0)remains valid. Clicking a post marker or pair button opens that post; criterion markers are not post buttons. Do not derive coordinates from rank, distance,Y/E/R/U, reconstruction/share terms, coverage, or axis count. Preserve deterministic identity/layout and current-parent ABAC.Canonical KO/EN/JA/ZH/VI/ES/DE/FR translation authority remains #922/#929/#932. Keep Draft until realistic current-parent RED, causal repair, exact-head repository/security GREEN, production build/Storybook, current responsive/pointer/touch/keyboard/focus/a11y browser evidence, translation-ledger convergence, applicable authenticated PostgreSQL/k6 acceptance, and qualifying independent approval are current. No force-push, destructive rebase, self-approval, parent bypass, or gate weakening.