Skip to content

fix(voice): preserve singleton relations across export pages - #968

Draft
seonghobae wants to merge 2 commits into
fix/voice-export-authority-20260828from
codex/voice-pagination-audit-20260907
Draft

fix(voice): preserve singleton relations across export pages#968
seonghobae wants to merge 2 commits into
fix/voice-export-authority-20260828from
codex/voice-pagination-audit-20260907

Conversation

@seonghobae

@seonghobae seonghobae commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Accumulating JSON-LD pages dropped earlier Voice relations when either page used a singleton value. Preserve supplied property values across singleton/array forms, retaining subject identity, existing labels, replay idempotency, and input immutability. This implements ADR 0256's existing union contract without new inference, Voice codes, API/schema changes, or release identities.

Stacked on #780 at 1d8fa267b059289e77301a09985dfac70a439814. Merge the parent under protection first, then retarget this child to main and collect fresh exact-head checks and independent approval. Existing parent work is preserved.

Validation: direct Node invocation reproduced relation loss before the repair and passed three singleton/array cases afterward, including replay and immutability assertions. Added the same cases to the existing Vitest regression suite. Lint passed. Vitest failed before executing tests because its process pool did not respond within the startup timeout, including after a project-local frozen/offline dependency installation; no warning or failing gate was suppressed. The production typecheck did not complete during the bounded audit and was stopped. Storybook started, but the desktop/mobile browser audit failed with navigation/control-wait timeouts. No screenshots or rendered acceptance are claimed.

The baseline records dated exact heads, current ruleset observations, canonical repository names, release-title collisions, and explicit evidence limits. No authenticated candidate PostgreSQL API or k6 capacity acceptance is claimed. No qualifying independent approval or merge SHA is claimed. Keep Draft until validation is complete.

@coderabbitai

coderabbitai Bot commented Sep 7, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant