feat(hris): add governed Employment work-capacity review - #103
feat(hris): add governed Employment work-capacity review#103seonghobae wants to merge 9 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughEmployment work-capacity review 패킷 패키지와 관련 문서, 테스트, GitHub Actions 품질 워크플로를 추가했다. 패킷은 입력 검증, canonical 증거, SHA-256 무결성, 시스템 기록 시각을 지원하며 운영 데이터를 변경하지 않는다. ChangesEmployment work-capacity review
Estimated code review effort: 4 (Complex) | ~45 minutes Merge Risk: ⚪ Minimal · up to This PR adds a bounded, non-authoritative Employment work-capacity review evidence contract without changing authoritative employment or compensation state. No actionable merge-blocking risk remains after normal checks and review. Sequence Diagram(s)sequenceDiagram
participant 호출자
participant 패킷빌더 as build_employment_work_capacity_review_packet
participant 패킷 as EmploymentWorkCapacityReviewPacket
participant 증거 as Canonical 증거
호출자->>패킷빌더: 검토 입력 전달
패킷빌더->>패킷: 시스템 recorded_at으로 생성
패킷->>증거: 정규화 및 SHA-256 digest 생성
증거-->>패킷: canonical 문서와 digest 반환
패킷-->>호출자: 검증된 패킷 반환
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 2📝 Generate docstrings 💡
🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
@opencode-agent Please review the current unchanged head against protected |
1 participant
Buyer-visible gap
develop@9e3e4847510e1e612b48474ba42b177b8ed824dfhas authoritative Employment and Assignment truth, but no bounded review evidence for a proposed change in one Employment's contracted work capacity before downstream bitemporal mutation. This Orgmetra-only lane adds that boundary without changing compensation, payroll, leave, scheduling, Assignment, or any foreign CWL repository.Current contract and test-first repairs
EmploymentWorkCapacityReviewPacketbinds authoritative tenant/Employment scope, exact finite four-decimal current/proposed capacity ratios, business effective date, human review time, owner-generated system-recorded time, exact SHA-256 employment-terms/capacity-policy/reviewer-identity evidence, distinct requester/reviewer correlations, controlled non-sensitive reason, and evidence version.The packet remains PII/value-minimized and fixed to
employment_work_capacity_review,reviewed_for_authoritative_resolution,not_authorized_to_change_employment_or_compensation, and mandatory human review. It does not classify legal employment status, infer suitability or availability for work, or authorize Employment, Assignment, compensation, payroll, leave, or scheduling mutation.Test-first repairs canonicalize zero capacity to
0.0000, reject signed negative zero, and remove caller authority over system-recorded time: Orgmetra generates UTCrecorded_atinside the constructor, independently from businesseffective_onand humanreviewed_at. Nil/Max UUID sentinels, malformed digests, runtime subclasses, noncanonical Decimal scale, actor overlap, review time after issuance, governance mutation, and post-issuance field mutation fail closed.Exact-current-head evidence — 2026-09-02
267d9d5bc58d2e951fe3e428876682c8a5e1daa5; protected base:develop@9e3e4847510e1e612b48474ba42b177b8ed824df.dependency-reviewconcluded success while the actualDependency reviewaction step was skipped. It predates the central fail-closed repair tracked by.github#810and must not be promoted as clean dependency evidence.Downstream ownership
PR #128 is the dependency-first child that persists reviewed work-capacity truth. It must not inherit this PR's checks or reviews. #103 must integrate first; then #128 must retarget to fresh
developand rerun every applicable local and central gate on its new exact head.Merge governance
Effective organization ruleset 18156473 —
CWL Central required workflowsremains active on the default branch and still requires one unavailable generic approval plus routineOrganizationAdmin/alwaysbypass. Issue #89 and central.github#772/#1351/#1176own the satisfiable solo-maintainer contract: approval count zero while no genuinely independent human reviewer exists, last-push approval disabled, no synthetic required reviewers, review-thread resolution and exact-head deterministic workflows retained, deletion/non-fast-forward protection retained, and routine admin bypass removed in favor of separately governed break-glass operation.This lane is therefore not merge-authorized. Refetch the rerun, exact head/base, reviews, unresolved threads, effective rules and checks before any future merge. Do not self-approve, use routine administrator bypass, transfer predecessor evidence, weaken/simulate protection, or treat a skipped Dependency Review action as successful evidence.