repair(network): restack committed-navigation subscription on live origin binding by seonghobae · Pull Request #277 · ContextualWisdomLab/OriginWeave

seonghobae · 2026-09-02T06:42:39Z

Repairs the active #28 subscription stack without force-pushing or closing stale PR #262.

Current deadline repair

Current head is 117f6414e8a6db46eb2b32f4ebae85cf2a208371, a normal follow-up commit after the verified parent adoption below. A real-socket regression observed no subscription bytes but two outstanding commands where only one pre-existing command should remain. The sender now reuses the frame owner's existing timeout validator before registration. Both zero and over-limit deadlines preserve the unrelated command and leave the rejected identifier reusable; no bound or wire format changes.

Post-registration frame failures still conservatively retain correlation. A separate real-socket test covers this unchanged path using repeated masking-key rejection after a successful empty Pong. The response parser, typed command family, origin binding, and Proposed ADR are unchanged.

Fresh verification for this new source tree passed 11 focused subscription loopback tests, all 142 Python contracts, the complete locked Rust workspace check/tests, format, all-feature Clippy, warning-denying rustdoc, compileall, and diff checks. Numeric production coverage is 100%: 1,221 functions, 12,781 lines, 16,404 regions, and 1,418 branches. The unstable branch-measurement warning remains. New hosted checks must finish independently; earlier coverage is not transferred.

Historical verified parent adoption

Parent-adoption head was 3c0484174eeda0703492ba76b530be125e3e99dd, a normal merge of child 01038ba71fb276426cc67f90a91a3c431e194db5 and actual #261 934eb7d37568b439c442ffe1d1f6a9c8f8ed58a0. Both release records and crate-level capability descriptions were retained when resolving the two documentation conflicts.

The two subscription production modules, three integration-test files, and Proposed ADR text are byte-identical to 01038ba7.... The child's existing NavigationCommittedSubscription command family remains the sole two-line addition to the parent's correlation enum; no generic compatibility shim was restored. The former suggestion to add SessionSubscribe is historical: the current implementation already uses typed subscription registration and response correlation.

Product boundary

The command subscribes only to committed navigation in one already-registered context, revalidates that binding before I/O, registers its typed command before a possible remote side effect, and uses the existing bounded verified WebSocket. The bounded opaque receipt remains private in diagnostics. Invalid or ambiguous results and command-kind mismatches preserve unrelated outstanding commands.

This is protocol-correlation evidence, not browser authentication, proof that an event occurred, or navigation/action/policy/secret authority. That parent-adoption commit retained the existing correlation behavior, including invalid deadlines. The subsequent repair above changes only rejection before registration; post-registration retention remains.

Parent-adoption local verification

Native discovery reproduced zero inherited command-correlation release-contract tests before adoption; after reusing the parent fix the same expected-one assertion and test pass. Fresh verification passed 16 focused loopback tests, all 142 Python contracts, Rust 1.97.1 format, locked workspace check/tests, all-feature Clippy, warning-denying rustdoc, compileall, and diff checks.

Production coverage on nightly 2026-08-01 is numerically 100%: 1,220 functions, 12,774 lines, 16,397 regions, and 1,418 branches. The measurement warning --branch option is unstable remains visible. These results are not hosted GREEN, protected-main integration, or real-browser completion.

Preserved historical repair evidence

The original #262 unique subscription delta was reconstructed rather than copied wholesale. Historical #277 head 74fdedb6ee441a4055ee335bc5a5b96dee852661 failed native CI 33600076214: Rust contracts job 100151610266 exposed formatting failures (artifact 9854587900, ZIP SHA-256 d1c6ff0f9ff8f0cd970a41ce61b804460987d6d7a0dee41acbf7af9a7bec3fd9), and coverage job 100151609938 exposed three removed generic-correlation calls. Current typed registration/correlation fixes that incompatibility without reviving confused-response routing.

Historical review 5094483494 corrected the overbroad objection to deterministic unwrap_or; the actual prohibited production expect was removed in the parent routing repair. These findings and predecessor results are not current-head verification.

Parent-first governance

Keep Draft and unmerged. Hosted checks and reviews must be independently evaluated for this new head; predecessor, queued, skipped, cancelled, model-only, or author-only results are not passing evidence or counted approval. Parent #261 must integrate under current policy before retargeting or protected merge.

Do not close #262 or promote #263+ merely because this reconstruction exists. Require current-parent hosted GREEN and complete unique-delta/successor evidence first. No self-approval, bypass, force update, destructive rebase, workflow/ruleset/secret mutation, gate weakening, tag, release, or publication was performed.

coderabbitai · 2026-09-02T06:42:49Z

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}