feat(sensitive): record credential-free handle lifecycle evidence - #45
feat(sensitive): record credential-free handle lifecycle evidence#45seonghobae wants to merge 11 commits into
Conversation
|
Warning Review limit reached
Next review available in: 27 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Partial implementation of #10.
Buyer/security gap
OriginWeave's protected-main sensitive-data policy already binds purpose, destination, classification, expiry and bounded handle-use authority, and its evidence crate records credential-free access decisions. The next bounded gap was lifecycle evidence for an opaque sensitive-value handle: issuance, expiry, use limit, observed resolution count and revocation must be auditable without putting the opaque handle token or the protected value into evidence.
Scope
This PR adds that narrow immutable value object to the existing
originweave-evidencecrate. It intentionally does not add a new workspace crate or modifyCargo.lockbecause current repository governance does not authorize scheduled lockfile changes for this task.SensitiveHandleLifecycleEvidencerecords only request ID, policy decision ID, trusted issuance/expiry epochs, maximum uses, observed resolution count and optional trusted revocation epoch. It has no field for an opaque handle token and no field for raw/protected data.Validation fails closed for invalid/bounded identifiers, zero/non-increasing lifetimes, zero use limits, over-limit resolution counts and revocation outside the handle lifetime.
TDD evidence
RED/GREEN evidence was established through exact-head repository Actions because the local execution container could not resolve github.com for an exact checkout.
b6b5b2746f4319454d6abf996f731291f8e77799first exposed a rustfmt setup defect; that was not counted as RED.31357517628reachedcargo check --locked --workspace --all-targetsand failed exactly becauseSensitiveHandleLifecycleEvidenceandSensitiveHandleLifecycleEvidenceInputdid not exist: valid production-boundary RED.expect()usage.0f07fea031090c72a448fd9501b49d4dd7568419is mergeable against live protected main67af7c87589edc2039545af335c95064d9b8391cand has exact-head CI31358358734, Security Scan31358358708, and SAST Semgrep31358358727all successful. CodeRabbit exact-head status is successful and no inline review threads are currently returned.No predecessor-head check or review is being transferred to the current head.
Explicit non-scope
This is not the trusted broker. It does not implement or claim protected-value storage/encryption/KMS, raw value resolution/fill, opaque-handle token storage, atomic use reservation/enforcement, revocation enforcement, cross-process/tenant persistence, model/provider/region disclosure policy, hash-chained durable audit sequencing, or the planned standalone
originweave-sensitive-dataauthority/service crate.Those remain open under #10. A stale scaffold branch for the standalone crate exists but is not reused or presented as current implementation evidence. Issue #10 now contains a lineage comment linking this bounded slice and explicitly warning against duplicate scaffold/broker work.
This PR must not close #10 and cannot be called shipped until protected integration and every applicable exact-head gate pass.