Skip to content

feat(psychometric): recover ESEM loadings and refuse reverse DSEM lags - #119

Open
seonghobae wants to merge 2 commits into
mainfrom
agent/psychometric-esem-dsem-fit
Open

feat(psychometric): recover ESEM loadings and refuse reverse DSEM lags#119
seonghobae wants to merge 2 commits into
mainfrom
agent/psychometric-esem-dsem-fit

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

Summary

  • ADR 0005 still required a CPU f64 ESEM/DSEM fit path that does not treat raw topic proportions as Euclidean indicators.
  • Adds standalone psychometric_fit: OLS recovers known exploratory cross-loadings from admitted ALR/ILR/logistic-normal coordinates; recovered RMSE is below a zero-loading collapse.
  • DSEM lagged paths are admitted only when the predictor is strictly earlier in event time.
  • A good global fit cannot reclassify formative or network constructs as reflective.
  • Does not recreate psychometric_core (feat(psychometric): posterior ESEM input gates with true-parameter RMSE #49 owns input gates) and does not allocate migration 0007/0008 (#45 still owns 0007).

Claim boundary

  • OLS loading recovery and event-time lag gates only. Not rotation, posterior pooling, invariance, or a full ESEM/DSEM sampler.
  • Not a certification, attestation, or causal-identification claim.

Test plan

  • RED: esem_dsem_fit_contract failed before the crate existed
  • cargo test -p psychometric_fit --offline --lib --tests
  • cargo clippy -p psychometric_fit --all-targets --offline -- -D warnings
  • cargo llvm-cov -p psychometric_fit authored lines 108/108; nightly-2026-08-01 branches 30/30
  • docstring, workspace, and documentation gates
  • Exact-head CI and independent review

Add a standalone psychometric_fit crate that recovers exploratory
cross-loadings on a CPU f64 OLS path from admitted log-ratio coordinates
and refuses non-forward event-time DSEM lags. Does not recreate
psychometric_core or allocate migration 0008.
@coderabbitai

coderabbitai Bot commented Aug 16, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 33 minutes

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

Wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d528a73f-ef71-42ff-8888-43d6c5744bea

📥 Commits

Reviewing files that changed from the base of the PR and between 7c29e7c and 2ea08a8.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (18)
  • ARCHITECTURE.md
  • CHANGELOG.md
  • Cargo.toml
  • README.md
  • crates/psychometric_fit/Cargo.toml
  • crates/psychometric_fit/src/error.rs
  • crates/psychometric_fit/src/fit.rs
  • crates/psychometric_fit/src/lib.rs
  • crates/psychometric_fit/tests/crate_contract.rs
  • crates/psychometric_fit/tests/esem_dsem_fit_contract.rs
  • docs/TRACEABILITY.md
  • docs/adr/0005-posterior-esem-dsem.md
  • docs/adr/README.md
  • docs/research/esem-dsem-fit.md
  • docs/research/standards-and-literature.md
  • docs/validation/temporal-event-foundation.md
  • scripts/check_workspace_contract.py
  • tests/quality/test_check_docstrings.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai

coderabbitai Bot commented Aug 16, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 1d94e3ee-819c-4a2b-997e-8b201edd8589

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

# Conflicts:
#	CHANGELOG.md
#	docs/validation/temporal-event-foundation.md
@seonghobae
seonghobae marked this pull request as ready for review August 20, 2026 18:54
@seonghobae

Copy link
Copy Markdown
Contributor Author

Current HEAD 2ea08a87be3c87d7d8c400addcdf0fd3e8e830d0 includes current main, the CPU f64 ESEM/DSEM acceptance contract, and the dynamic workspace crate-count quality fix. Verified at this HEAD: cargo fmt --all -- --check; cargo test -p psychometric_fit --offline (8 tests including known-loading RMSE and forward event-time contracts); Python quality suite (89 tests); workspace, documentation, Rust docstring, and diff checks. Please provide the required independent approval; merge remains gated until current-head required checks and approval are present.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant