feat(api): inspect stored analysis-run requests via loopback CLI - #395
Conversation
GAP-003A / issue #166: operators can inspect metric-free snapshot, cutoff, model contract, and output profile through `tepp-analysis-runs stored-request` without writing raw HTTP. tepp.scientific_acceptance.v1 never appears. Stacked on stored-request consumer-parity (#387) over stored-request GET (#377). Does not duplicate retry CLI, cancel/create/status CLIs, or GET-by-id.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hour-24 exact-head: |
seonghobae
left a comment
There was a problem hiding this comment.
Exact-head COMMENT on a99cdc7 (draft). Unique occupied: tepp-analysis-runs stored-request for GET /v1/analysis-runs/{run_id}/request (ADR 0041) stacked on stored-request HTTP #377. Metric-free snapshot/cutoff/model-contract/output-profile inspect. tepp.scientific_acceptance.v1 never appears. Do not duplicate stored-request HTTP/CLI. Do not un-quarantine unscoped stored-request-by-client-key (ADR 0099 lives on #466). Do not un-draft. Zero reviews on this SHA before this COMMENT. Never self-approve. Persistence remains GAP-003B. Do not weaken fail-closed. No Buyer language.
Why
GAP-003A / issue #166 still required operators to write raw HTTP/1.1 after stored-request GET. Operators cannot inspect snapshot, cutoff, model contract, and output profile of a listed run from a client without guessing framing. Stdout stays metric-free.
tepp.scientific_acceptance.v1never appears.Live slices that this PR does not duplicate:
analysis_enginescientific-acceptance librarytepp-analysis-run)listtepp-retry)e2ffc6d1cbb6c2f972efd69f236ac5cd918113e6)What
GAP-003A stored-request CLI stacked on #387 over stored-request GET
#377/ protected main1bc02f580cf48e1d39da239f0e818453437c31c3:tepp-analysis-runs stored-requestclient ofGET /v1/analysis-runs/{run_id}/requesttepp.scientific_acceptance.v1never printsNot an ADR 0014 scientific claim. Not persistence.
Verification
cargo clippy -p tepp_api --all-targets -- -D warningscargo test -p tepp_api --lib analysis_run_stored_request_clicargo test -p tepp_api --test analysis_run_stored_request_cli_contractRUSTDOCFLAGS='-D warnings' cargo doc -p tepp_api --no-depspython3 scripts/validate_documentation.pypython3 scripts/check_docstrings.pyExact head:
a99cdc77d26488f01c2deb7501dc691bc820ad02Do not merge without two independent APPROVE reviews on this exact head and current Checks. Author COMMENTED is not independent APPROVE.