fix(validation): preserve representable recovery metrics - #488
Draft
seonghobae wants to merge 541 commits into
Draft
fix(validation): preserve representable recovery metrics#488seonghobae wants to merge 541 commits into
seonghobae wants to merge 541 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validation Evidence authority
Protected base is
main@a243f18da4a4ca8a8d068c39922537f1f8ed6ad0. This Draft remains the owner-correct Validation Evidence landing vehicle. Productionvalidation_core::bias_standard_errorexact pair-distance admission is deliberately unchanged atn=4..=16; issue #491 anddocs/research/bias-standard-error-wide-linear-admission-bound.mdcarry the measured exact-proof budget decision and scientific trace.GAP-125 remains the latest public-value repair: RED
5da82b2d651706c191ca191c6c077d916cbfda25→ repaira509ae9e46c8ffc2cc3ef4f0e904774ad2516e1f. The authoritative exact-rounding primitive was subsequently widened for two-limb scaled comparisons by REDf7717361ad8c5f0592688c1514c104cc1b4adabe→ repaire4a85f53a611922be7492fe906d62ce65787c18e, with tie-to-even edge contract1240ace8eb41a01fa72a4bb99df842fd550a1288.#491 resource finding now under test
7a2ab0a1ef7a72d8cc9b9253d7f92c493e578943proves pairwise O(n²) and Wide256 O(n) exact-ratio equivalence on represented{0,1,2^53}geometries atn=4,16,17,65,257,2050, including the 129-bit cancellation-product boundary atn=2050.New characterization
2bc1d2284d75154e020640adb573c1cfadf005fbisolates a different admission boundary inside the existingn=4budget. Residuals[0,1,2^-54,2]have exact minimum-anchor coordinates, while non-anchor1 - 2^-54rounds in binary64 and makes the current pairwise-f64 proof refuse. On common unit2^-54, exact integer coordinates[0,2^54,1,2^55]produce the same pair numerator through direct integer pair distances andn*Σc_i²-(Σc_i)²:3569704090242693886528325169446915.The public metric already returns the correctly represented
0x3fdea33e2c83c140through the generic fallback. This is therefore a proof-admission/resource finding, not a public-value defect: exact non-anchor pair subtraction is sufficient for the current O(n²) reference but is not a scientific prerequisite when canonical anchor-relative coordinates are exact.Doctoring is current through CHANGELOG fragment
8050b4918803e69d8746167948a216d90a0cbd5aand research trace/current headea592b32a0733ede28390945e70c332a2cb4f3a5. Production routing has not yet moved to the anchor-linear/Wide256 numerator path, pairwise fail-closed comparison remains in place, and the sample budget has not widened.Foundation prerequisite #492
#492 is Ready for Review at
794ba9e6dda9f043aa499920fdf609b81b075d7e. Its Rust Foundation, Documentation Quality, Security Scan, and Semgrep evidence is terminal GREEN, but CodeQL fails in the canonical owner control plane before the scan matrix starts..github/main@fb2ae81dbeaacb0c630e51e9d772c6919fa220cfrun34014663536reaches metadata binding with actor/senderopencode-agent[bot];.github#1899records the allowlist asgithub-actions[bot]and treats authorization of the actual app principal as an explicit owner security decision. TEPP will not change that allowlist, impersonate an allowed actor, or weaken the gate. #492 is not inherited here until it reaches protected main through the normal path.Current delivery state
Exact #488 head is
ea592b32a0733ede28390945e70c332a2cb4f3a5, Draft and mergeable on the protected base. Current-head required workflows were queued/pending at the latest sweep; no exact-head GREEN or qualifying independent approval is claimed. Pinned Rustfmt artifact9982621569remains predecessor-only evidence from1f765a....docs/product-technical-gap-baseline.mdon #435 is still stale relative to this head, and canonicaldocs/TRACEABILITY.mdstill lacks a direct #491 resource-route row. They remain explicit doctoring gaps.Merge policy
No force push, destructive rebase, self-approval, required-gate weakening, mutable sibling dependency, routine admin bypass, or fabricated benchmark/CI evidence. Before any production budget change: integrate canonical anchor-relative normalization and Wide256 numerator routing in the owning module under TDD; preserve pairwise comparison until same-domain equivalence and intended anchor-linear-only admissions are proven; retain exact midpoint/tie-to-even semantics; obtain Rust 1.98.0 release-mode raw CPU/allocator/RSS evidence; make TRACEABILITY/baseline current; and obtain exact-head Rust/rustdoc/100% line+branch/security/documentation GREEN plus qualifying independent review.