Skip to content

security: remove tracked Packrat build artifacts#160

Open
seonghobae wants to merge 2 commits into
masterfrom
agent/afipc-supply-chain
Open

security: remove tracked Packrat build artifacts#160
seonghobae wants to merge 2 commits into
masterfrom
agent/afipc-supply-chain

Conversation

@seonghobae

Copy link
Copy Markdown
Collaborator

Pull Request

Summary

  • Remove the generated packrat/lib installation tree (1,851 tracked files, about 58 MB), including 11 Linux .so/.deb build artifacts reported by Scorecard SARIF.
  • Keep packrat.lock, packrat/init.R, and packrat/src so the legacy opt-in environment remains reproducible; ignore restored packrat/lib, packrat/lib-R, and packrat/lib-ext trees.
  • Replace unpinned pip install yamllint and npm install -g markdownlint-cli2 workflow commands with full-SHA-pinned actions, addressing Scorecard PinnedDependenciesID alerts chore(deps): bump step-security/harden-runner from 2.14.2 to 2.15.0 #14 and chore(deps): bump step-security/harden-runner from 2.14.2 to 2.15.1 #15.
  • Update repository guidance to distinguish tracked dependency sources from generated installed libraries.

Validation

  • R_PROFILE_USER=/dev/null Rscript -e 'testthat::test_local(reporter="summary")'
  • Clean staged-tree R CMD build succeeded
  • Clean staged-tree R CMD check --no-manual --as-cran: 0 errors, 0 warnings, 3 pre-existing NOTEs
  • yamllint, markdownlint-cli2, and actionlint succeeded
  • Fresh Trivy DB scan (vuln,secret,misconfig, Medium+) found no issues; OSV reported no supported package source for this legacy R lock format
  • Tracked compiled artifact inventory is empty
  • Unpinned pip/npm install workflow command inventory is empty
  • No secrets or credentials were added

Risk and Rollback

  • Risk level: medium (large generated-tree deletion; package source and mathematical behavior are unchanged)
  • Rollback plan: revert commit ee92fdd; the ignored installed tree can also be regenerated through the existing opt-in Packrat bootstrap.

Behavioral Impact

  • R/aFIPC.R unchanged
  • If changed, regression evidence is attached

Checklist

  • Docs updated (README.md, ARCHITECTURE.md, CONTRIBUTING.md) as needed
  • New/updated GitHub Actions use full commit SHA pinning
  • Security policy / contribution policy alignment verified

Copilot AI review requested due to automatic review settings July 21, 2026 00:50

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

Copilot AI review requested due to automatic review settings July 21, 2026 02:46

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

@opencode-agent opencode-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

OpenCode could not approve from deterministic current-head evidence because GitHub Checks have failed.

Findings

1. HIGH Current-head GitHub Checks - Fix failed required checks before approval

  • Problem: Failed same-head checks remain for 804ea97cd83144f94c5020a9d42f2573cc8cb442.
  • Root cause: The model-unavailable evidence fallback is allowed only when peer GitHub Checks are complete and clean.
  • Fix: Read and fix the failed check logs below, then rerun the current-head checks.
  • Regression test: Keep the model-unavailable fallback gated on an empty failed-check rollup.

Failed checks:

Changed-File Evidence Map

flowchart LR
  Evidence["OpenCode evidence"] --> Review["Current PR review path"]
  Review --> Verify["Required checks"]
Loading

@opencode-agent

opencode-agent Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

OpenCode Review Overview

  • Head SHA: 804ea97cd83144f94c5020a9d42f2573cc8cb442
  • Workflow run: 29826062413
  • Workflow attempt: 1
  • Gate result: REQUEST_CHANGES (approval step)

Pull request overview

OpenCode could not approve from deterministic current-head evidence because GitHub Checks have failed.

Findings

1. HIGH Current-head GitHub Checks - Fix failed required checks before approval

  • Problem: Failed same-head checks remain for 804ea97cd83144f94c5020a9d42f2573cc8cb442.
  • Root cause: The model-unavailable evidence fallback is allowed only when peer GitHub Checks are complete and clean.
  • Fix: Read and fix the failed check logs below, then rerun the current-head checks.
  • Regression test: Keep the model-unavailable fallback gated on an empty failed-check rollup.

Failed checks:

Changed-File Evidence Map

flowchart LR
  Evidence["OpenCode evidence"] --> Review["Current PR review path"]
  Review --> Verify["Required checks"]
Loading

@opencode-agent opencode-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

OpenCode could not approve from deterministic current-head evidence because GitHub Checks have failed.

Findings

1. HIGH Current-head GitHub Checks - Fix failed required checks before approval

  • Problem: Failed same-head checks remain for 804ea97cd83144f94c5020a9d42f2573cc8cb442.
  • Root cause: The model-unavailable evidence fallback is allowed only when peer GitHub Checks are complete and clean.
  • Fix: Read and fix the failed check logs below, then rerun the current-head checks.
  • Regression test: Keep the model-unavailable fallback gated on an empty failed-check rollup.

Failed checks:

Changed-File Evidence Map

flowchart LR
  Evidence["OpenCode evidence"] --> Review["Current PR review path"]
  Review --> Verify["Required checks"]
Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants