๐จ Palette: ContextSection ์ ๋ถํ์ํ Chevron ์คํฌ๋ฆฐ๋ฆฌ๋ ์ถ๋ ฅ ์ ๊ฑฐ - #297
๐จ Palette: ContextSection ์ ๋ถํ์ํ Chevron ์คํฌ๋ฆฐ๋ฆฌ๋ ์ถ๋ ฅ ์ ๊ฑฐ#297seonghobae wants to merge 2 commits into
Conversation
Added aria-hidden="true" to the ChevronUp and ChevronDown icons in the ContextSection component to prevent screen readers from reading them out loud, as the state is already conveyed by aria-expanded on the parent button.
|
๐ Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a ๐ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
There was a problem hiding this comment.
Pull request overview
ContextSection(๋์๋ณด๋ ๋ฆฌํฌํธ UI)์ ํ ๊ธ ๋ฒํผ์์ ์ฅ์์ฉ Chevron ์์ด์ฝ์ด ์คํฌ๋ฆฐ๋ฆฌ๋์ ์ค๋ณต์ผ๋ก ์ฝํ์ง ์๋๋ก ์ ๊ทผ์ฑ ์์ฑ์ ๋ณด์ํ๋ PR์ ๋๋ค.
Changes:
- ํ ๊ธ ์ํ ์์ด์ฝ(ChevronUp/ChevronDown)์
aria-hidden="true"๋ฅผ ์ถ๊ฐํด ๋ณด์กฐ๊ธฐ์ ์์ ์ฅ์ ์์๋ฅผ ์จ๊น - (๋ถ์์ ์ผ๋ก) ํ์ผ ์ ๋ฐ์ ๋ฌธ์์ด/์ธ๋ฏธ์ฝ๋ก /ํฌ๋งทํ ์ด ํจ๊ป ๋ณ๊ฒฝ๋จ
๐ก Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "use client"; | ||
|
|
||
| import React, { useState, useId, type ReactNode } from 'react' | ||
| import { ChevronDown, ChevronUp } from 'lucide-react' | ||
| import { cn } from '@/lib/utils' | ||
| import React, { useState, useId, type ReactNode } from "react"; | ||
| import { ChevronDown, ChevronUp } from "lucide-react"; | ||
| import { cn } from "@/lib/utils"; |
| aria-expanded={open} | ||
| aria-controls={contentId} | ||
| > | ||
| <h2 className="text-base font-medium">{title}</h2> |
Updated multiple dependencies in `package.json` overrides to address high and moderate severity vulnerabilities detected by osv-scanner. Includes updates for `hono`, `js-yaml`, `sharp`, `@hono/node-server`, `fast-uri`, `brace-expansion`, and `body-parser`.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated 6 comments.
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
Comments suppressed due to low confidence (1)
packages/web/src/components/dashboard/reports/context-section.tsx:5
- ์ด ํ์ผ๋ง "use client"/import ๊ตฌ๋ฌธ์ด ์๋ฐ์ดํ+์ธ๋ฏธ์ฝ๋ก ์คํ์ผ๋ก ๋ณ๊ฒฝ๋์ด, ๊ฐ์ ๋๋ ํฐ๋ฆฌ์ ๋ค๋ฅธ ์ปดํฌ๋ํธ๋ค(์: week-navigator.tsx)๊ณผ ์ฝ๋ ์คํ์ผ์ด ๋ถ์ผ์นํฉ๋๋ค. PR ๋ชฉ์ ์ด ์ ๊ทผ์ฑ ์์ฑ ์ถ๊ฐ๋ผ๋ฉด ํฌ๋งทํ ๋ณ๊ฒฝ์ diff ๋ ธ์ด์ฆ๋ฅผ ํค์ฐ๋ฏ๋ก, ์ ์ฅ์์์ ์ฌ์ฉ ์ค์ธ ํฌ๋งคํฐ/๋ฆฐํธ ๊ท์น์ ๋ง๊ฒ ํ์ชฝ์ผ๋ก ํต์ผํ๋ ํธ์ด ์ข์ต๋๋ค.
"use client";
import React, { useState, useId, type ReactNode } from "react";
import { ChevronDown, ChevronUp } from "lucide-react";
import { cn } from "@/lib/utils";
| "sharp": ">=0.35.0", | ||
| "@hono/node-server": ">=2.0.5", |
| "sharp": ">=0.35.0", | ||
| "@hono/node-server": ">=2.0.5", |
| "hono": "^4.12.27", | ||
| "js-yaml": "^4.3.0" |
| sharp: '>=0.35.0' | ||
| '@hono/node-server': '>=2.0.5' |
| hono: ^4.12.27 | ||
| js-yaml: ^4.3.0 |
| sharp@0.35.3: | ||
| resolution: {integrity: sha512-ej0zVHuZGHCiABXcNxeYhpRnPNPAcvbG8RMdBAhDAxLKkCRVSpK3Iyu7qbqw3JMzoj0REeM6f3tJLtVwl0023Q==} | ||
| engines: {node: '>=20.9.0'} |
|
Superseded by #266, which contains the same |
Understood. Acknowledging that this work is superseded by #266 and stopping work on this task. |
๐ก What: ContextSection ์ปดํฌ๋ํธ์ ํ ๊ธ ๋ฒํผ์ ์๋ ChevronUp/ChevronDown ์์ด์ฝ์ `aria-hidden="true"` ์์ฑ์ ์ถ๊ฐํ์ต๋๋ค.
๐ฏ Why: ์ด๋ฏธ ๋ถ๋ชจ `button` ์์๊ฐ `aria-expanded`๋ฅผ ํตํด ์ํ๋ฅผ ์๋ ค์ฃผ๊ณ ์์ผ๋ฏ๋ก, ๋ถํ์ํ ์ฅ์์ฉ ์์ด์ฝ๊น์ง ์คํฌ๋ฆฐ๋ฆฌ๋๊ฐ ์ฝ์ด๋ฒ๋ฆฌ๋ ๋ฌธ์ ๋ฅผ ๋ฐฉ์งํ๊ธฐ ์ํจ์ ๋๋ค. ์ด๋ฅผ ํตํด ์๊ฐ ์ฅ์ ์ธ ์ฌ์ฉ์๊ฐ ๊ฒช๋ ์ธ์ง ๋ถํ๋ฅผ ์ค์ผ ์ ์์ต๋๋ค.
๐ธ Before/After: ์๊ฐ์ ๋ณํ ์์ (HTML Semantic ์์ฑ๋ง ๋ณ๊ฒฝ)
โฟ Accessibility: ์ฅ์์ฉ/์ค๋ณต ์ ๋ณด๋ฅผ ์ ๊ณตํ๋ ์์ด์ฝ์ ๋ณด์กฐ ๊ธฐ์ ์์ ์จ๊ฒจ, ๋ณด๋ค ๊น๋ํ ์คํฌ๋ฆฐ ๋ฆฌ๋ ๊ฒฝํ์ ์ ๊ณตํฉ๋๋ค.
PR created automatically by Jules for task 14707259237627725677 started by @seonghobae