Skip to content

๐Ÿ›ก๏ธ Sentinel: [CRITICAL] Fix SQL Injection via Mutation Bypass in ERDModel - #407

Closed
seonghobae wants to merge 2 commits into
developmentalfrom
fix-erd-mutation-bypass-8247406468370849225
Closed

๐Ÿ›ก๏ธ Sentinel: [CRITICAL] Fix SQL Injection via Mutation Bypass in ERDModel#407
seonghobae wants to merge 2 commits into
developmentalfrom
fix-erd-mutation-bypass-8247406468370849225

Conversation

@seonghobae

Copy link
Copy Markdown
  • ๐Ÿšจ Severity: CRITICAL
  • ๐Ÿ’ก Vulnerability: ERDModel์—์„œ ๊ฐ์ฒด์˜ ์ฐธ์กฐ๊ฐ€ ๋…ธ์ถœ๋˜์–ด ์™ธ๋ถ€์—์„œ ๊ฒ€์ฆ ์šฐํšŒ ๋ฐ ์•…์˜์ ์ธ DDL ๊ตฌ๋ฌธ ์ฃผ์ž…(SQL Injection)์ด ๊ฐ€๋Šฅํ•œ ์ทจ์•ฝ์ ์ด ๋ฐœ๊ฒฌ๋˜์—ˆ์Šต๋‹ˆ๋‹ค.
  • ๐ŸŽฏ Impact: ์•…์˜์ ์ธ DDL ๊ตฌ๋ฌธ์ด ์ฃผ์ž…๋˜์–ด ๋ฐ์ดํ„ฐ๋ฒ ์ด์Šค์˜ ํ…Œ์ด๋ธ”์„ ์ž„์˜๋กœ ์‚ญ์ œํ•˜๊ฑฐ๋‚˜ ๋ณ€์กฐํ•  ์ˆ˜ ์žˆ์Šต๋‹ˆ๋‹ค.
  • ๐Ÿ”ง Fix: ERDModel์—์„œ ๋‚ด๋ถ€ ์ƒํƒœ๋ฅผ ๋ฐ˜ํ™˜ํ•˜๊ฑฐ๋‚˜ ํŒŒ๋ผ๋ฏธํ„ฐ๋ฅผ ๋‚ด๋ถ€ ๋ฐฐ์—ด์— ์ €์žฅํ•  ๋•Œ `structuredClone()`์„ ์‚ฌ์šฉํ•˜์—ฌ ๊นŠ์€ ๋ณต์‚ฌ(deep copy)๋ฅผ ํ•˜๋„๋ก ์ˆ˜์ •ํ•˜์˜€์Šต๋‹ˆ๋‹ค.
  • โœ… Verification: ํ…Œ์ŠคํŠธ ์ผ€์ด์Šค(erd.test.ts)๊ฐ€ ์ •์ƒ์ ์œผ๋กœ ์ˆ˜ํ–‰๋˜๋Š” ๊ฒƒ์„ ํ™•์ธํ•˜์˜€์Šต๋‹ˆ๋‹ค.

PR created automatically by Jules for task 8247406468370849225 started by @seonghobae

@google-labs-jules

Copy link
Copy Markdown

๐Ÿ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a ๐Ÿ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 9 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
โš™๏ธ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 4c2e54b4-7568-4258-a9f9-7342035fe520

๐Ÿ“ฅ Commits

Reviewing files that changed from the base of the PR and between 4f8796e and a8b5420.

โ›” Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
๐Ÿ“’ Files selected for processing (4)
  • .jules/sentinel.md
  • package.json
  • packages/web/src/lib/erd.test.ts
  • packages/web/src/lib/erd.ts

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Author

Closing as superseded by #397. The current #407 head (a8b5420248acb2e014222286120b6e643440aa32) addresses the mutation-bypass subset by cloning getter results and caller-owned Column/ForeignKey objects. The current #397 head (547c238f37d0d439e055940f24ada3debafbfae8) contains that same defensive ownership boundary with explicit primitive copies and regression coverage, and additionally closes the broader DDL injection boundary with SQL-type/default allow-lists, runtime type validation, identifier quoting, security doctoring, and resolved CodeRabbit findings. Keeping both would duplicate the same security repair on the same developmental base and create competing merge lineages. No checks, reviews, or approvals from #407 are transferred to #397; #397 must satisfy its own exact-current-head gates before merge.

@seonghobae seonghobae closed this Aug 7, 2026
@google-labs-jules

Copy link
Copy Markdown

Closing as superseded by #397. The current #407 head (a8b5420248acb2e014222286120b6e643440aa32) addresses the mutation-bypass subset by cloning getter results and caller-owned Column/ForeignKey objects. The current #397 head (547c238f37d0d439e055940f24ada3debafbfae8) contains that same defensive ownership boundary with explicit primitive copies and regression coverage, and additionally closes the broader DDL injection boundary with SQL-type/default allow-lists, runtime type validation, identifier quoting, security doctoring, and resolved CodeRabbit findings. Keeping both would duplicate the same security repair on the same developmental base and create competing merge lineages. No checks, reviews, or approvals from #407 are transferred to #397; #397 must satisfy its own exact-current-head gates before merge.

Understood. Acknowledging that this work is now obsolete and superseded by #397, and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant