feat: add metadata-only handoff export - #305
Conversation
|
Warning Review limit reached
More reviews will be available in 42 minutes and 14 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthrough
Changes메타데이터 전용 핸드오프 기능
Sequence Diagram(s)sequenceDiagram
participant User
participant Workspace
participant export_ts as export.ts
participant shared_types as shared-types
User->>Workspace: "Export Handoff (JSON)" 버튼 클릭
Workspace->>export_ts: generateMetadataHandoffJson(song, {sourceBootstrap, workspaceId, workspaceTitle})
export_ts->>export_ts: createMetadataHandoffArtifact() 호출 (섹션/roleBucket 매핑)
export_ts->>shared_types: parseMetadataHandoffArtifact(payload)
shared_types-->>export_ts: MetadataHandoffArtifact (검증 통과)
export_ts-->>Workspace: JSON 문자열
Workspace->>Workspace: downloadTextFile()로 *_handoff.json 다운로드
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
Caution Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional.
❌ Failed checks (1 error)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/desktop/src/App.tsx`:
- Line 348: The Workspace component in the return statement at line 348 is
receiving jobResult and a separately tracked selectedBootstrap, which can become
misaligned. When users select a new file after a successful analysis completes,
the old jobResult gets paired with new selectedBootstrap metadata, breaking
consistency between the analysis result and its source. Instead of passing the
current selectedBootstrap state directly, you need to capture and store which
bootstrap was actually used at the time the jobResult was obtained, then pass
that captured bootstrap to the Workspace component. This ensures the handoff
metadata always reflects the bootstrap source that generated the jobResult, not
whatever the user has currently selected.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 10cbf1e7-383c-49dd-964f-0a137bc7c326
📒 Files selected for processing (7)
apps/desktop/src/App.tsxapps/desktop/src/features/workspace/Workspace.test.tsxapps/desktop/src/features/workspace/Workspace.tsxapps/desktop/src/lib/export.test.tsapps/desktop/src/lib/export.tspackages/shared-types/src/index.tspackages/shared-types/test/index.test.ts
Addressed in fdf6830; CodeRabbit marked the thread resolved/outdated on the current head.
OpenCode Review Overview
OpenCode Agent approved this PR. The changes in PR #305 are well-tested and do not introduce any critical issues. The modifications in
|
![opencode-agent[bot]](https://avatars.githubusercontent.com/in/1549082?s=60&v=4){kind=small}
There was a problem hiding this comment.
OpenCode Agent approved this PR.
The changes in PR #305 are well-tested and do not introduce any critical issues. The modifications in App.test.tsx ensure proper metadata handling, and the updates to shared types and workspace logic are consistent with the existing architecture. No security, privacy, or regression risks were identified.
- Result: APPROVE
- Reason: No critical issues found in the changes. The PR includes thorough test coverage and maintains existing functionality.
- Head SHA:
fdf6830cb2a3f9ba34d8dd9bf22d415cfe6486d1 - Workflow run: 27535532165
- Workflow attempt: 1
1 participant
Summary
Verification
Security Notes
Closes #150