feat(security): add standalone directory credential registry - #354
feat(security): add standalone directory credential registry#354seonghobae wants to merge 5 commits into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Read-only child-head review request for @opencode-agent review |
Rate Limit Exceeded
|
Objective
Advance issue #319 with a standalone, provider-neutral local credential-store adapter on the exact #344 registry contract. The adapter resolves purpose-scoped, versioned key material without making raw environment values the long-lived runtime authority.
Exact stack identity
56c001eff8bc683153844170c616e03c0a884878;d7321e0c29c38553f6e0fa089a9e659d91d08b8a;DirectoryCredentialRegistry.javaand its focused test only;Contract
The read-only adapter requires canonical purpose metadata, an exact active version, bounded opaque key bytes, safe credential/version identifiers, and fail-closed handling of missing, blank, malformed, mismatched, non-canonical, empty, oversized, or symlinked registry state. Returned snapshots inherit #344's defensive secret copying and redacted diagnostics.
Scope boundary
This slice does not migrate
TenantAccessService,ArtifactLinkService,ProductionAuthReadinessConfig, or production bootstrap. It does not implement writes, distributed cache, compatibility-window rotation, KMS custody, or a vendor-specific adapter.Merge gate
Keep Draft while #344 remains unmerged. Child CI/fuzz success is review evidence, not protected-main merge evidence. After #344 reaches protected
main, rebuild or retarget this two-file delta onto the new exact protected base and regenerate all main-targeted CI, Security Scan, SAST, fuzz, current-head reviews, and qualifying independent approval. No predecessor evidence transfers.