fix(viewer): report only qualified renderer metadata - #386
Open
seonghobae wants to merge 3 commits into
Open
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthrough
Changes렌더러 어댑터 변경
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
seonghobae
marked this pull request as ready for review
August 11, 2026 13:17
seonghobae
enabled auto-merge (squash)
August 11, 2026 19:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Remove misleading production viewer-bootstrap adapter claims. Protected main currently reports
DOCX_PREVIEW,SHEET_ADAPTER,SLIDE_ADAPTER, andTEXT_ADAPTERbased only on the source filename even though the shipped viewer renders the converted PDF through PDF.js and transformed-format production conversion fails closed when no qualified converter is configured.Test-first state
This Draft starts intentionally RED at exact test-only head
ce9be547a3a3e0e9cddffbd6899f5e91b355615f, directly based on protectedmain55d7ae8647208e301f282350f076eeddaba61d11.ViewerBootstrapResponseTestnow requires the bootstrap to report only the actually qualifiedPDF_JSrenderer while preserving normalized source-extension metadata. Protected main still synthesizes unqualified source-family adapter names, so the focused test is expected to fail before production repair.Scope
Bounded viewer-bootstrap product-truth fix under issue #317 and the fail-closed fidelity boundary of issue #5. It does not change Office conversion, PDF.js runtime code, viewer/session authentication, demo.js/dom-utils.js, tenant lifecycle, OpenAPI, credential/OIDC work, or canonical documentation owned by active PR #305.
Acceptance
Observe exact-head RED -> smallest production mapping repair -> focused/full
mvn -B --no-transfer-progress verifywith exact 100% owned production coverage and warning-free public Javadocs -> CI/Security Scan/SAST/fuzz -> current reviews/threads/live-base refetch. Keep Draft until exact-head GREEN evidence exists. Qualifying independent non-author approval remains a separate protected-merge gate.Summary by CodeRabbit