Skip to content

๐ŸŽจ Palette: ํŒŒ์ผ ๋ชฉ๋ก ํ˜ธ๋ฒ„(Hover) ์‹œ ๋ฐ‘์ค„ ํšจ๊ณผ ๋ณต์› - #620

Closed
seonghobae wants to merge 2 commits into
masterfrom
palette-hover-underline-fix-17721940346798866804
Closed

๐ŸŽจ Palette: ํŒŒ์ผ ๋ชฉ๋ก ํ˜ธ๋ฒ„(Hover) ์‹œ ๋ฐ‘์ค„ ํšจ๊ณผ ๋ณต์›#620
seonghobae wants to merge 2 commits into
masterfrom
palette-hover-underline-fix-17721940346798866804

Conversation

@seonghobae

@seonghobae seonghobae commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

Verified successor disposition

The valid defect is real: once a translated .visually-hidden type label became the last child inside each link, span:last-child no longer selected the rendered filename and hover/focus underlining disappeared.

This branch repairs that symptom with span:nth-child(2), but the positional selector remains coupled to child order and its regression only asserts the CSS literal. The generated .jules/palette.md addition also tries to generalize this local DOM shape into repository doctrine.

Canonical #599 now fully carries the valid behavior on current protected master with a stronger semantic contract. Exact successor head b811d4721ab3940774e88d1ed73bbfd89137d3a5 adds .entry-name only to visible parent/file-name spans, targets that class for hover, focus-visible and active states, rejects span:last-child, verifies the real rendered row keeps .icon and .visually-hidden outside the target, restores protected Palette doctrine, and has been non-force restacked so it is behind_by=0 against master@728f0f33323e43573d6664209891099502827d5d.

#599 is still Draft with fresh current-head CI/security/SAST/CodeQL queued; no gate evidence transfers from this branch. No unique valid semantic/test/contract delta remains here once the positional implementation and repository-wide doctrine are rejected. This close is therefore verified-successor consolidation, not simple PR-count reduction.

@google-labs-jules

Copy link
Copy Markdown

๐Ÿ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a ๐Ÿ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. ๐ŸŽ‰

โ„น๏ธ Recent review info
โš™๏ธ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 260731c8-0412-4469-af1f-ba2611c1c82b

๐Ÿ“ฅ Commits

Reviewing files that changed from the base of the PR and between 728f0f3 and 15be83a.

๐Ÿ“’ Files selected for processing (3)
  • .jules/palette.md
  • src/main/kotlin/html4tree/main.kt
  • src/test/kotlin/html4tree/GeneratedIndexReadabilityTest.kt

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


๐Ÿ“ Walkthrough

Walkthrough

๋งํฌ์˜ ํ˜ธ๋ฒ„ ๋ฐ ํ‚ค๋ณด๋“œ ํฌ์ปค์Šค ๋ฐ‘์ค„ ์„ ํƒ์ž๋ฅผ ํ‘œ์‹œ ํŒŒ์ผ๋ช…์— ๋งž๊ฒŒ ๋ณ€๊ฒฝํ–ˆ์Šต๋‹ˆ๋‹ค. ๊ด€๋ จ ํ…Œ์ŠคํŠธ๋ฅผ ๊ฐฑ์‹ ํ•˜๊ณ , ์ˆจ๊น€ ํ…์ŠคํŠธ๋กœ ์ธํ•ด ๋ฐ‘์ค„ ๋Œ€์ƒ์ด ๋ณ€๊ฒฝ๋˜๋Š” ์ ‘๊ทผ์„ฑ ๋ฌธ์ œ๋ฅผ ๋ฌธ์„œํ™”ํ–ˆ์Šต๋‹ˆ๋‹ค.

Changes

๋งํฌ ๋ฐ‘์ค„ ์ ‘๊ทผ์„ฑ ์ˆ˜์ •

Layer / File(s) Summary
ํ‘œ์‹œ ํŒŒ์ผ๋ช… ๋ฐ‘์ค„ ์„ ํƒ์ž ๋ฐ ๊ฒ€์ฆ
.jules/palette.md, src/main/kotlin/html4tree/main.kt, src/test/kotlin/html4tree/GeneratedIndexReadabilityTest.kt
ํ˜ธ๋ฒ„ ๋ฐ ํฌ์ปค์Šค ๋ฐ‘์ค„ ๋Œ€์ƒ์„ span:last-child์—์„œ span:nth-child(2)๋กœ ๋ณ€๊ฒฝํ–ˆ์Šต๋‹ˆ๋‹ค. ๊ด€๋ จ ํ…Œ์ŠคํŠธ์™€ ์ ‘๊ทผ์„ฑ ์„ค๋ช…์„ ๊ฐฑ์‹ ํ–ˆ์Šต๋‹ˆ๋‹ค.

Estimated code review effort: 1 (๋งค์šฐ ๋‹จ์ˆœ) | ~3 minutes

Merge Risk: โšช Minimal ยท up to 151f2

Hover and keyboard-focus underlining now targets the visible filename rather than hidden accessibility text. The accessibility label remains intact, and no merge-blocking risk is evident.

๐Ÿšฅ Pre-merge checks | โœ… 4 | โŒ 1

โŒ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage โš ๏ธ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. (1 skipped: 1 โ€ฆ Write docstrings for the functions missing them to satisfy the coverage threshold.
โœ… Passed checks (4 passed)
Check name Status Explanation
Description Check โœ… Passed Check skipped - CodeRabbitโ€™s high-level summary is enabled.
Title check โœ… Passed ์ œ๋ชฉ์€ ํŒŒ์ผ ๋ชฉ๋ก์˜ ํ˜ธ๋ฒ„ ์‹œ ๋ฐ‘์ค„ ํšจ๊ณผ๋ฅผ ๋ณต์›ํ•˜๋Š” ์ฃผ์š” ๋ณ€๊ฒฝ ์‚ฌํ•ญ์„ ์ •ํ™•ํ•˜๊ณ  ๊ฐ„๊ฒฐํ•˜๊ฒŒ ์„ค๋ช…ํ•ฉ๋‹ˆ๋‹ค.
Linked Issues check โœ… Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check โœ… Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. (1 skipped: 1 unsupported.)

โœจ Finishing Touches ๐Ÿ’ก 1
๐Ÿ“ Generate docstrings ๐Ÿ’ก
  • Create stacked PR
  • Commit on current branch
๐Ÿงช Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch palette-hover-underline-fix-17721940346798866804

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

โค๏ธ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant