test(react): eliminate collaborative reset act warning - #95
Closed
seonghobae wants to merge 1 commit into
Closed
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closed — RED did not reproduce
This Draft was created to reproduce a current protected-main React
not wrapped in act(...)warning for theCollaborativeCwlEditornative-form reset path before making any production/test-harness repair.Fresh exact-head evidence on
0e2e10a856d56f73376c7ce1a6039cb34040edcddisproved that premise:src/components/editorFormSerialization.test.tsxpassed without the claimed React act warning in the captured job log.src/components/collaborativeFormResetWarning.test.tsxalso passed and observed nonot wrapped in actdiagnostic.Under the repository's test-first/systematic-debugging contract, a test that is expected to be RED but is GREEN cannot justify a speculative fix. This PR therefore closes without changing production behavior or adding a regression whose motivating failure was not reproduced.
If a future exact protected head emits the warning again, reopen the investigation from that exact log/commit and first reproduce the warning with a focused failing test before modifying code.