Skip to content

fix(trust): roll audited central workflow source to 2396ddc - #554

Draft
seonghobae wants to merge 15 commits into
mainfrom
fix/trusted-workflow-source-rollforward-dd0b96
Draft

fix(trust): roll audited central workflow source to 2396ddc#554
seonghobae wants to merge 15 commits into
mainfrom
fix/trusted-workflow-source-rollforward-dd0b96

Conversation

@seonghobae

@seonghobae seonghobae commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Scope

Roll Noema's exact job_workflow_sha trust binding to the current protected central .github source commit. Noema consumes the protected reusable-workflow source identity only; provider/model routing, retry/failover, Strix/security, outbound authority and other foreign-owner implementation stay in their canonical repositories.

Current exact authority — 2026-09-07 KST

Protected Noema is main@8cbb07da2a9a7e4e9b782c40bf7b6a1567e7b18d. Protected central .github/main is GitHub-verified 2396ddcaf4b6c50785548b313ccddfa1784915a2. Exact 49eb9e7...2396ddc is three commits ahead and changes only scripts/ci/pr_review_merge_scheduler_core.py, tests/test_pr_review_merge_scheduler.py, and tests/test_required_workflow_queue_contract.py; .github/workflows/noema-review.yml retains the identical blob f8ab55c896e8b40dde0bddd89bab37868dda9283 at both source commits. Because Noema validates GitHub OIDC job_workflow_sha, the protected commit-source identity must still roll forward even when the reusable-workflow blob itself is unchanged.

RED → causal fix

Predecessor bf9e46af38994e32cfc2faed3de1c565897d0025 bound Noema to central 49eb9e7... and became deterministically stale when protected central advanced. Test-only a7484066ec5eb503f66df0b04baf5faab196f90a changes only test/trusted-workflow-source-rollforward.test.ts to require 2396ddc..., creating the intended RED against the predecessor wrangler.toml. Production 1900f05f51efa186508ce84d281a32fc9c2b39f7 changes only wrangler.toml.ALLOWED_WORKFLOW_SHA to the same exact protected central source.

No provider/model discovery, retry/failover, scheduler implementation, Strix/security, quarantine, or outbound authority moved into Noema. Both writes stayed on the existing branch; no force rewrite occurred.

Current exact head is 1900f05f51efa186508ce84d281a32fc9c2b39f7, open / Draft / mergeable with zero inline review threads. Fresh exact-head CI 34053586570, patch-validator-image 34053586595, reviewer-ci 34053586634, and required Security Scan 34053586671 are non-terminal. All predecessor workflow evidence is non-authorizing. Keep Draft until these exact-head gates are terminal GREEN and live protected/central heads plus review authority are re-read.

@coderabbitai

coderabbitai Bot commented Sep 6, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Contributor Author

Fresh trust audit on current protected authorities:

  • Noema protected main remains e26d771470a4ece873c367b40b3cd6cb03ac7de3; central protected .github/main is dd0b96feded94f66ecf59b25a5a9b58cfc8b4f69.
  • GitHub's current OIDC reference states that job_workflow_sha is the commit SHA for the reusable workflow file. Because this consumer trusts ContextualWisdomLab/.github/.github/workflows/noema-review.yml@refs/heads/main, the fail-closed allowlist must follow the audited commit identity resolved for that protected ref; blob equality alone is not the claim Noema validates.
  • Fresh GitHub compare 43024633eba9d96b0456970391360da5a171fbda...dd0b96feded94f66ecf59b25a5a9b58cfc8b4f69 shows central changes in OpenCode/Strix/contextual-orchestrator dispatch, tests/ADR/CHANGELOG and does not list .github/workflows/noema-review.yml as a changed file. That supports the narrow production repair here: only the audited job_workflow_sha source commit changes; provider/model routing, retry/failover, sandbox/security and outbound authority remain in their canonical owners.
  • Current PR diff remains exactly the RED contract plus wrangler.toml.ALLOWED_WORKFLOW_SHA roll-forward (apart from final-newline normalization). No gate weakening or unrelated source was introduced.

Hosted exact-head CI/reviewer/Security/image remain non-terminal, so this is audit evidence only, not GREEN or merge-readiness evidence.

@seonghobae seonghobae changed the title fix(trust): roll audited central workflow source to dd0b96 fix(trust): roll audited central workflow source to ee5567 Sep 6, 2026
@seonghobae seonghobae changed the title fix(trust): roll audited central workflow source to ee5567 fix(trust): roll audited central workflow source to 6e014c9 Sep 6, 2026
@seonghobae seonghobae changed the title fix(trust): roll audited central workflow source to 6e014c9 fix(trust): roll audited central workflow source to 9aad23c Sep 6, 2026
@seonghobae seonghobae changed the title fix(trust): roll audited central workflow source to 9aad23c fix(trust): roll audited central workflow source to ad0779b Sep 6, 2026
@seonghobae seonghobae changed the title fix(trust): roll audited central workflow source to ad0779b fix(trust): roll audited central workflow source to 49eb9e7 Sep 6, 2026
@seonghobae seonghobae changed the title fix(trust): roll audited central workflow source to 49eb9e7 fix(trust): roll audited central workflow source to 2396ddc Sep 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant