Skip to content

fix(governance): restack independent approval audit after nanoid - #90

Open
seonghobae wants to merge 3 commits into
mainfrom
fix/governance-independent-approval-after-nanoid
Open

fix(governance): restack independent approval audit after nanoid#90
seonghobae wants to merge 3 commits into
mainfrom
fix/governance-independent-approval-after-nanoid

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Purpose

Clean protected-main successor to superseded #87 after #76 integrated. This PR starts from current protected main and replays only #87's unique governance/Security-Scan guidance delta; predecessor and sibling checks/reviews do not transfer.

Test-first proof

Exact RED head f0ee29936cc3f46f38c04b5f32992396e4b543fa ran application CI and failed exactly two intended contracts in test/main-governance-audit.test.ts:

  1. the protected-main evaluator did not fail when required_approving_review_count was zero;
  2. protected-main AGENTS.md still claimed central Security Scan ran on every stacked PR and documented a stale CRITICAL/HIGH threshold.

The narrow GREEN implementation then changed only:

  • test/main-governance-audit.test.ts;
  • scripts/lib/main-governance-audit.mjs;
  • AGENTS.md.

Current exact head: 4ee417372c7a7e084767b50692c376bf03ff4b0a.

Implemented boundary

  • the repository-owned main-governance evaluator now requires at least one active pull-request rule with a positive generic approving-review count while retaining the existing separate CODEOWNERS hold;
  • review/check/status/scanner/model evidence remains distinct and no model/status/comment becomes approval;
  • AGENTS.md now matches the live central Security Scan event contract: protected bases (main, master, develop) are eligible, feature-base absence is non-passing evidence that must be refreshed after dependency integration, and the fixable Trivy boundary is MEDIUM/HIGH/CRITICAL;
  • no fix(security): update transitive nanoid for CVE-2026-67213 #76 lockfile/CI/doctoring/changelog changes are replayed because they are already protected-main truth.

Current exact-head verification

For unchanged exact head 4ee417372c7a7e084767b50692c376bf03ff4b0a:

  • application ci run 31366570251: terminal success;
  • reviewer-ci run 31366570220: terminal success;
  • central Security Scan run 31366570232: terminal success under its own scanner/revision semantics;
  • formal GitHub reviews: none at the latest fresh read;
  • inline review threads: none at the latest fresh read;
  • GitHub reports the PR mergeable and it is now Ready for review.

The successful technical gates do not create live ruleset evidence or a qualifying independent formal approval. Issue #27 remains the enforceable-governance owner and #29 remains the Reviewer/Maintainer App provisioning owner.

Supersession

#87 was closed only after proving this clean protected-main successor preserves its three unique final blobs exactly. Old #87 checks/reviews do not transfer.

No repair workflow, self-modifying Action, force-push, synthetic approval, protection weakening, version bump, release or deployment authority is introduced.

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 39 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 6087bd5a-0f78-42a4-8b9c-1d77d5c9d5f0

📥 Commits

Reviewing files that changed from the base of the PR and between c85d710 and 4ee4173.

📒 Files selected for processing (3)
  • AGENTS.md
  • scripts/lib/main-governance-audit.mjs
  • test/main-governance-audit.test.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant