π¨ Palette: Add loading spinners to project dialogs - #1
Conversation
This commit adds a small `Loader2` spinner to the submit/delete buttons of the `DeleteProjectDialog`, `RenameProjectDialog`, and `NewProjectDialog` when their state is pending. This provides immediate visual feedback to the user during asynchronous operations.
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π Walkthroughκ°μμΈ κ°μ νλ‘μ νΈ κ΄λ¦¬ λν μμ(μμ , μμ±, μ΄λ¦ λ³κ²½)μ λ³κ²½ μ¬νλ‘λ© μν UI κ°μ
μμ μ½λ 리뷰 μμ μκ°π― 2 (λ¨μ) | β±οΈ ~10λΆ ν λΌμ μΆν μ
Caution Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional.
β Failed checks (1 error)
β Passed checks (4 passed)
β¨ Finishing Touchesπ Generate docstrings
π§ͺ Generate unit tests (beta)
β¨ Simplify code
Comment |
Meta-audit checkpoint #1 (cycle 260602-01): the exact `toHaveBeenCalledWith` RequestInit object asserted header-construction form, not behavior. Behavior is already covered by the written-config assertion; keep the endpoint check with expect.anything() for the request init. Records audit conclusions in learnings (gates LOC already reviewed; session heartbeat schema deferred). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
ν΅ν© PRμμ μ ν¨ λ³κ²½λ§ μ λ³ν΄ λ€μ λ€λ£¨κ³ μμ΄ μ΄ μ€λ³΅/μμ¬ PRμ μ 리ν©λλ€. #39 λ° vibemafiaclub/vooster#34λ₯Ό κΈ°μ€μΌλ‘ νμ κ²ν λ₯Ό μ§νν©λλ€. |
π‘ What: Added
Loader2loading spinners to the submit buttons of three project-related dialogs (DeleteProjectDialog,RenameProjectDialog,NewProjectDialog).π― Why: To provide immediate, clear visual feedback to the user when an asynchronous operation (like creating, renaming, or deleting a project) is in progress, preventing confusion or double-clicks.
βΏ Accessibility: Included
aria-hidden="true"on theLoader2icon so screen readers do not redundantly announce the decorative spinner, since the button text already changes to indicate the loading state.PR created automatically by Jules for task 10756574501519691107 started by @seonghobae