๐จ Palette: [UX improvement] Fix accessible collapsible tables - #28
๐จ Palette: [UX improvement] Fix accessible collapsible tables#28seonghobae wants to merge 1 commit into
Conversation
Update `UsecaseTable` and `ActorTable` to hide content `<tbody>` elements with a CSS class instead of conditionally unmounting them. This ensures the controlled `id` remains in the DOM, maintaining the link with the toggle button's `aria-controls` attribute for screen readers. Co-authored-by: Palette <palette@vspec.dev>
|
๐ Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a ๐ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning Review limit reached
More reviews will be available in 36 minutes and 3 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running โ you're only billed for reviews past your plan's rate limits ($0.25/file). โ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. ๐ฆ How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. โน๏ธ Review infoโ๏ธ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ๐ Files selected for processing (17)
โจ Finishing Touches๐งช Generate unit tests (beta)
โจ Simplify code
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
ํตํฉ PR์์ ์ ํจ ๋ณ๊ฒฝ๋ง ์ ๋ณํด ๋ค์ ๋ค๋ฃจ๊ณ ์์ด ์ด ์ค๋ณต/์์ฌ PR์ ์ ๋ฆฌํฉ๋๋ค. #39 ๋ฐ vibemafiaclub/vooster#34๋ฅผ ๊ธฐ์ค์ผ๋ก ํ์ ๊ฒํ ๋ฅผ ์งํํฉ๋๋ค. |
๐ก What: Modified
UsecaseTableandActorTableto toggle the visibility of the collapsible groups using a CSShiddenclass instead of conditional React rendering (unmounting).๐ฏ Why: When
<tbody>elements are conditionally removed from the DOM, theidtarget for the toggle button'saria-controlsattribute disappears. Screen readers require the controlled element to exist in the DOM to properly interpret the relationship.๐ธ Before/After:
aria-controlslink.display: none(hidden), keeping the semantic structure intact for assistive technologies.โฟ Accessibility: Fixes orphaned
aria-controlsattributes on collapsible table toggle buttons, improving the experience for screen reader users when interacting with grouped data. Added a critical learning entry to.jules/palette.md.PR created automatically by Jules for task 2147253668076563768 started by @seonghobae