Skip to content

๐ŸŽจ Palette: [UX improvement] Fix accessible collapsible tables - #28

Closed
seonghobae wants to merge 1 commit into
mainfrom
palette-fix-accessible-collapsible-tables-2147253668076563768
Closed

๐ŸŽจ Palette: [UX improvement] Fix accessible collapsible tables#28
seonghobae wants to merge 1 commit into
mainfrom
palette-fix-accessible-collapsible-tables-2147253668076563768

Conversation

@seonghobae

Copy link
Copy Markdown

๐Ÿ’ก What: Modified UsecaseTable and ActorTable to toggle the visibility of the collapsible groups using a CSS hidden class instead of conditional React rendering (unmounting).

๐ŸŽฏ Why: When <tbody> elements are conditionally removed from the DOM, the id target for the toggle button's aria-controls attribute disappears. Screen readers require the controlled element to exist in the DOM to properly interpret the relationship.

๐Ÿ“ธ Before/After:

  • Before: Collapsing a group unmounted the rows, breaking the aria-controls link.
  • After: Collapsing a group simply applies display: none (hidden), keeping the semantic structure intact for assistive technologies.

โ™ฟ Accessibility: Fixes orphaned aria-controls attributes on collapsible table toggle buttons, improving the experience for screen reader users when interacting with grouped data. Added a critical learning entry to .jules/palette.md.


PR created automatically by Jules for task 2147253668076563768 started by @seonghobae

Update `UsecaseTable` and `ActorTable` to hide content `<tbody>` elements with a CSS class instead of conditionally unmounting them. This ensures the controlled `id` remains in the DOM, maintaining the link with the toggle button's `aria-controls` attribute for screen readers.

Co-authored-by: Palette <palette@vspec.dev>
@google-labs-jules

Copy link
Copy Markdown

๐Ÿ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a ๐Ÿ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Jun 15, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@seonghobae, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 36 minutes and 3 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running โ€” you're only billed for reviews past your plan's rate limits ($0.25/file).

โŒ› How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

๐Ÿšฆ How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

โ„น๏ธ Review info
โš™๏ธ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: fbdf09a5-7d8b-4ad2-9d90-500551e0662a

๐Ÿ“ฅ Commits

Reviewing files that changed from the base of the PR and between cb2b2da and e0b747e.

๐Ÿ“’ Files selected for processing (17)
  • .jules/palette.md
  • apps/app/app/components/ActorTable.tsx
  • apps/app/app/components/UsecaseTable.tsx
  • goals/43-dogfood-usecase-verify-returns-opaque-output-with-no-pass-.md
  • goals/44-dogfood-usecase-show-human-format-omits-the-extensions-sec.md
  • goals/48-dogfood-usecase-verify-produces-opaque-output-with-no-pass.md
  • goals/52-dogfood-usecase-create-title-validator-title-not-verb-phra.md
  • goals/54-dogfood-usecase-verify-produces-no-usable-output-so-the-ag.md
  • goals/55-dogfood-usecase-verify-returns-opaque-output-with-no-pass-.md
  • goals/65-dogfood-verify-flags-unlinked-steps-demands-implements-ref.md
  • goals/67-dogfood-vspec-usecase-verify-produces-no-meaningful-output.md
  • goals/70-dogfood-title-verb-phrase-validator-false-positives-on-leg.md
  • goals/71-dogfood-vspec-actor-show-name-leaks-raw-apierror-api-reque.md
  • goals/72-dogfood-scenario-add-does-not-surface-the-new-scenario-id-.md
  • goals/73-dogfood-first-push-self-conflicts-on-local-markdown-the-ag.md
  • goals/74-dogfood-vspec-usecase-verify-with-no-key-leaks-raw-apierro.md
  • goals/75-dogfood-not-found-errors-emit-a-misleading-default-vspec-l.md
โœจ Finishing Touches
๐Ÿงช Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch palette-fix-accessible-collapsible-tables-2147253668076563768
โœจ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch palette-fix-accessible-collapsible-tables-2147253668076563768

Warning

Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

โค๏ธ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@seonghobae

Copy link
Copy Markdown
Author

ํ†ตํ•ฉ PR์—์„œ ์œ ํšจ ๋ณ€๊ฒฝ๋งŒ ์„ ๋ณ„ํ•ด ๋‹ค์‹œ ๋‹ค๋ฃจ๊ณ  ์žˆ์–ด ์ด ์ค‘๋ณต/์ž”์—ฌ PR์€ ์ •๋ฆฌํ•ฉ๋‹ˆ๋‹ค. #39 ๋ฐ vibemafiaclub/vooster#34๋ฅผ ๊ธฐ์ค€์œผ๋กœ ํ›„์† ๊ฒ€ํ† ๋ฅผ ์ง„ํ–‰ํ•ฉ๋‹ˆ๋‹ค.

@seonghobae seonghobae closed this Jul 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant