Skip to content

๐ŸŽจ Palette: Accessible collapsible tables - #30

Closed
seonghobae wants to merge 11 commits into
mainfrom
jules-123350083057277681-fe1f6886
Closed

๐ŸŽจ Palette: Accessible collapsible tables#30
seonghobae wants to merge 11 commits into
mainfrom
jules-123350083057277681-fe1f6886

Conversation

@seonghobae

Copy link
Copy Markdown

๐Ÿ’ก What: Refactored the UsecaseTable and ActorTable components to maintain the contents of collapsed rows in the DOM by wrapping them in a hidden <tbody> instead of completely unmounting them. A matching aria-controls attribute has also been added to the toggle buttons.

๐ŸŽฏ Why: In previous implementation, collapsing the rows removed the target id from the DOM entirely. Screen readers rely on aria-controls referencing an existing DOM node id to establish the relationship between the toggle and the content. If the content is unmounted, this link is broken, leading to poor accessibility.

๐Ÿ“ธ Before/After: See the generated screenshots below which show that the tables render successfully when using multiple <tbody> components.

โ™ฟ Accessibility: Enhanced the collapsible group structure to natively support screen readers utilizing aria-expanded and aria-controls correctly over a consistently available DOM element (hidden via CSS).


PR created automatically by Jules for task 123350083057277681 started by @seonghobae

@google-labs-jules

Copy link
Copy Markdown

๐Ÿ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a ๐Ÿ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@seonghobae, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 55 minutes and 32 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running โ€” you're only billed for reviews past your plan's rate limits ($0.25/file).

โŒ› How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

๐Ÿšฆ How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

โ„น๏ธ Review info
โš™๏ธ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: cb57ed67-a1d2-47af-acbe-5236083b686a

๐Ÿ“ฅ Commits

Reviewing files that changed from the base of the PR and between cb2b2da and f49a03d.

๐Ÿ“’ Files selected for processing (4)
  • .jules/palette.md
  • apps/app/app/components/ActorTable.tsx
  • apps/app/app/components/UsecaseTable.tsx
  • apps/cli/tests/e2e-cli/UC-033.test.ts
โœจ Finishing Touches
๐Ÿงช Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jules-123350083057277681-fe1f6886
โœจ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch jules-123350083057277681-fe1f6886

Warning

Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

โค๏ธ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@seonghobae

Copy link
Copy Markdown
Author

@copilot ๋ฆฌ๋ทฐ์™€ ๋กœ๊ทธ๋ฅผ ํ™•์ธํ•˜์—ฌ ๋ฒ„๊ทธ๋ฅผ ํ•ด๊ฒฐํ•˜์„ธ์š”.

@google-labs-jules

Copy link
Copy Markdown

@copilot ๋ฆฌ๋ทฐ์™€ ๋กœ๊ทธ๋ฅผ ํ™•์ธํ•˜์—ฌ ๋ฒ„๊ทธ๋ฅผ ํ•ด๊ฒฐํ•˜์„ธ์š”.

I have successfully analyzed the GitHub CI Check Suite logs and resolved the issue. The failure was caused by a mismatch in an assertion within apps/cli/tests/e2e-cli/UC-033.test.ts. An earlier commit had updated the copy in the ai-guide.ts file, but the e2e test was still expecting the old string. I have updated the expected string in the test to match the new content, and confirmed the fix by running the test suite locally.

When both analysis attempts fail to produce a valid findings.json,
synthesise findings from result.json instead of exiting non-zero.
- is_error:false โ†’ task_succeeded:true, P2 finding (analysis timeout)
- is_error:true/null โ†’ task_succeeded:false, P1 finding (budget/error)

Fixes dogfood-analyze-fallback integration tests.

Copilot AI commented Jun 16, 2026

Copy link
Copy Markdown

@copilot ๋ฆฌ๋ทฐ์™€ ๋กœ๊ทธ๋ฅผ ํ™•์ธํ•˜์—ฌ ๋ฒ„๊ทธ๋ฅผ ํ•ด๊ฒฐํ•˜์„ธ์š”.

The CI failures were in apps/cli/tests/integration/dogfood-analyze-fallback.test.ts. The tests expected dogfood-analyze.sh to write fallback findings from result.json when the analyzer (claude) times out, but the script was exiting non-zero instead.

Fixed in commit fix: write fallback findings when dogfood analyzer times out:

  • After both analyzer attempts fail to produce findings.json, the script now reads result.json from the run directory
  • is_error: false โ†’ writes task_succeeded: true with a P2 finding
  • is_error: true (or missing) โ†’ writes task_succeeded: false with a P1 finding (includes budget error text in evidence)
  • If result.json is also absent, the original hard error is preserved

Also fixed a subtle jq bug where .is_error // true would incorrectly return true even when is_error is explicitly false (jq's // replaces both null and false).

@seonghobae

Copy link
Copy Markdown
Author

@copilot ๋ฆฌ๋ทฐ์™€ ๋กœ๊ทธ๋ฅผ ํ™•์ธํ•˜์—ฌ ๋ฒ„๊ทธ๋ฅผ ํ•ด๊ฒฐํ•˜์„ธ์š”. ๊ทธ๋ฆฌ๊ณ  merge conflicts๊ฐ€ ์žˆ์œผ๋ฉด ํ•ด๊ฒฐํ•˜์„ธ์š”. Base branch ์ตœ์‹  ๋ณ€๊ฒฝ ์‚ฌํ•ญ์„ fetch ํ•ด๋„ ๋ฉ๋‹ˆ๋‹ค. Python์„ ์‚ฌ์šฉํ•˜๋Š” ๊ฒฝ์šฐ Python GIL Issue ์‚ฌ์œ ๋กœ Python 3.14 ์ด์ƒ ๋ฒ„์ „์„ ์‚ฌ์šฉํ•˜์‹ญ์‹œ์˜ค. DB๋ฅผ ์“ฐ๋Š” ๊ฒฝ์šฐ ๋ชจ๋“  DB ์ด๋ฆ„ ๊ฐ์ฒด๋Š” ๋‘ ๋‹จ์–ด ์ด์ƒ ์กฐํ•ฉ์œผ๋กœ ๊ตฌ์„ฑ๋œ snake case์—ฌ์•ผ ํ•ฉ๋‹ˆ๋‹ค. OpenCode Agent๊ฐ€ ์‹คํŒจํ•˜๋Š” ๊ฒฝ์šฐ ๋“ฑ์—๋„ ๋Œ€์‘ํ•˜์—ฌ ๋ฒ„๊ทธ๋ฅผ ๊ณ ์น˜์‹ญ์‹œ์˜ค.

@seonghobae

Copy link
Copy Markdown
Author

ํ†ตํ•ฉ PR์—์„œ ์œ ํšจ ๋ณ€๊ฒฝ๋งŒ ์„ ๋ณ„ํ•ด ๋‹ค์‹œ ๋‹ค๋ฃจ๊ณ  ์žˆ์–ด ์ด ์ค‘๋ณต/์ž”์—ฌ PR์€ ์ •๋ฆฌํ•ฉ๋‹ˆ๋‹ค. #39 ๋ฐ vibemafiaclub/vooster#34๋ฅผ ๊ธฐ์ค€์œผ๋กœ ํ›„์† ๊ฒ€ํ† ๋ฅผ ์ง„ํ–‰ํ•ฉ๋‹ˆ๋‹ค.

@seonghobae seonghobae closed this Jul 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants