-
-
Notifications
You must be signed in to change notification settings - Fork 309
Issue 212: Implementing forward transfer #493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 212: Implementing forward transfer #493
Conversation
Pull Request Test Coverage Report for Build 716166603
💛 - Coveralls |
|
Hi @ryanlindeborg , thank you for the work! You raised two interesting points.
I'll keep you posted on both points! |
|
In general, right now it is not straightforward to implement metrics that assume access to the entire stream. Regarding forward transfer, the main problem is the access to future tasks. I think the plugin should: Ideally, the plugin should keep track of the experiences already used for training and evaluation. For example, if I have: Then, the plugin must call eval inside Then, the plugin does not need to call |
|
Keep in mind that if we go ahead with this solution I need to make some changes to allow calling |
|
Sorry for the long delay @ryanlindeborg . I collected your changes (so that your contribution is not lost) in the PR #695 and converted your code to be compliant to the changes done to the metrics during the last months. Feel free to check the PR out and suggest any changes. Thanks again for your effort 😄 |
This PR addresses this issue: #212.
It is a work-in-progress still. @AndreaCossu would you be able to provide some feedback on whether I am headed in the right direction here so far? I still have to figure out the best way to compute the predictions at random initialization, given that at other points in the strategy we just call "self._current_accuracy.update(strategy.mb_y, strategy.logits)" to calculate the accuracy at that point.
Also, what is the best way to think about testing an additional metric like this? Thanks for the guidance!