Skip to content

Conversation

@ggraffieti
Copy link
Member

@ggraffieti ggraffieti commented Apr 6, 2021

  • Now the pep8 check takes into consideration all the source files inside avalanche/, alongside tests (folder tests/) and examples (folder examples/).
  • Fix the existing pep8 issues in those files.
  • Deprecated tests removed.
  • Delete now useless test utils method (they were used to download the MNIST dataset from a mirror, now integrated into torchvision).

This PR solves issue #499

@ggraffieti ggraffieti linked an issue Apr 6, 2021 that may be closed by this pull request
@coveralls
Copy link

Pull Request Test Coverage Report for Build 724053992

  • 18 of 19 (94.74%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 76.221%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tests/test_metrics.py 1 2 50.0%
Totals Coverage Status
Change from base Build 721954277: -0.1%
Covered Lines: 6475
Relevant Lines: 8495

💛 - Coveralls

@vlomonaco vlomonaco merged commit 143bc46 into ContinualAI:master Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PEP8 checking for tests and examples

3 participants