Optimizations in ScaledSlider - #3881
Merged
Merged
Conversation
jacomago
reviewed
Jul 13, 2026
| * </p> | ||
| */ | ||
| private void adjustSizes(){ | ||
| SliderSkin skin = (SliderSkin) slider.getSkin(); |
Contributor
There was a problem hiding this comment.
Why remove this line? You are now calling this method twice.
Collaborator
Author
There was a problem hiding this comment.
Refactored this a bit. In general avoiding explicit cast if not necessary.
|
jacomago
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As suggested by Mr Claude: do not adjust sizes of the slider UI elements on value change, only on size change.
Also tweaked default sizes a bit to make a fresh ScaledSlider resemble the native JavaFX slider with default paddings.
Testing:
Documentation: