fix(showcase): gate LGP AAPL tool-rendering fixture on toolName not hasToolResult - #5292
Merged
Merged
Conversation
…asToolResult The D6 cell tool-rendering-custom-catchall for langgraph-python timed out (deterministic 30s no-response). The probe sends two turns in one thread: turn 1 "weather in Tokyo" -> get_weather, turn 2 "What's the current price of AAPL?" -> get_stock_price. The AAPL first-leg fixture was gated on hasToolResult:false, but aimock implements that gate as messages.some(m => m.role === "tool") -- i.e. ANY tool message anywhere in the thread. Turn 1's get_weather leaves a tool result in the thread, so on turn 2 hasToolResult is permanently true and the false gate can never match -> no_fixture_match -> 503 -> 30s timeout. Replace the broken hasToolResult:false gate with toolName:"get_stock_price" (the same pattern the sibling weather/chain first-leg fixtures already use). A toolName gate fires whenever the tool is registered, regardless of prior tool results; the toolCallId follow-up fixture still wins on iteration 2. Fixture-only change. Verified locally via the D6 Docker path: tool-rendering-custom-catchall now green (turn 1 get_weather + turn 2 get_stock_price both render, no 503/timeout); tool-rendering-default-catchall still green (no regression).
jpr5
requested review from
marthakelly,
mme,
ranst91 and
tylerslaton
as code owners
June 6, 2026 05:36
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📣 Social Copy GeneratorGenerate social media copies (Twitter/X, LinkedIn, Blog Post) for this PR using Claude.
|
Contributor
Production Digest-Pinning AuditAudit could not run this round. ErrorRun 2026-06-05 22:36:20 PDT — 0 finding(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The D6 cell
tool-rendering-custom-catchallfor langgraph-python deterministically timed out (30s no-response). The probe sends two turns in one thread: turn 1 "weather in Tokyo" ->get_weather, turn 2 "What's the price of AAPL?" ->get_stock_price. The AAPL first-leg fixture was gated onhasToolResult:false, but aimock implements that gate asmessages.some(m => m.role === "tool")— i.e. ANY tool message anywhere in the thread. Turn 1'sget_weatherleaves a tool result, so on turn 2hasToolResultis permanently true and the false gate can never match ->no_fixture_match-> 503 -> 30s timeout.This replaces the broken
hasToolResult:falsegate withtoolName:"get_stock_price"(the same pattern the sibling weather/chain first-leg fixtures already use). AtoolNamegate fires whenever the tool is registered, regardless of prior tool results; thetoolCallIdfollow-up fixture still wins on iteration 2.Fixture-only change.
Verification
Proven in a prior session via the D6 Docker path:
tool-rendering-custom-catchallnow green (turn 1get_weather+ turn 2get_stock_priceboth render, no 503/timeout);tool-rendering-default-catchallstill green (no regression).