fix(api): standardize response envelopes and resolve API test failures (#385) - #548
Open
Abdullahi-Code9 wants to merge 1 commit into
Open
Conversation
|
@Abdullahi-Code9 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #385
Summary
This PR standardizes the API response formats across all endpoints to resolve payload wrapping inconsistencies and fix cascading test failures in the listener service (#385).
Key Changes
API Envelope Standardization:
GET /healthinsrc/api/events-server.tsto return direct, unwrapped JSON objects required by health contract tests.notifications-historyandtemplates-apihandlers to ensure consistent payload structures usingsendJson/ standardized response helpers.Database & Schema Fixes:
next_retry_at) fromschema.sqlCREATE TABLE statements and handled migration safety indatabase.ts.scheduled-notification-repository.ts.notification_templatesschema conflicts.Compiler & Test Environment Fixes:
setTtlMs) insrc/store/event-registry.ts.@stellar/stellar-sdkandnode-cacheto ensure consistent unit test isolation..unref()) allowing Jest workers to exit cleanly.Verification
All 78 tests across the 6 API test suites under
src/api/are now passing 100% green:events-server.health.test.ts(12 tests)events-server.test.tsnotifications-history.test.ts(9 tests)templates-api.test.tsrate-limiter.test.tsexecution-metrics-api.test.ts(5 tests)Test Command Executed:
npm test -- src/api/