feat(agent): paste images into conversations#206
Merged
Conversation
| const preview = await screen.findByRole('dialog', { name: 'Your attachment' }) | ||
| const previewImage = preview.querySelector('img')! | ||
| fireEvent.contextMenu(previewImage, { clientX: 120, clientY: 130 }) | ||
| menu = await screen.findByRole('menu', { name: 'Image actions' }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
This implements the image capability explored in #197 as a native core-agent feature, using the existing conversation, provider, Media, and tool-loop architecture instead of adding a parallel attachment or storage path.
User and developer impact
Users can attach multiple images with optional text, send image-only turns, inspect images in a compact gallery/preview, and use copy, download, or Save to Media actions. The per-message limit protects a single provider request; long conversations are not assigned an artificial image count and are bounded naturally by provider context handling.
Unsupported models and invalid or oversized images fail before persistence. Conversation images remain private, authenticated chat data unless the user explicitly chooses Save to Media, which creates a separate public Media asset and requires
media.write.The shared TypeBox request contract, browser/server limits, capability semantics, persistence behavior, replay rules, context actions, and race handling are documented in
docs/features/agent.md,docs/features/media.md, and the HTTP boundary reference.Verification
bun run buildbun run lintgit diff --check