fix(canvas): hide empty chrome for ambient styles - #263
Merged
Conversation
DavidBabinec
marked this pull request as ready for review
July 24, 2026 14:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
:is(...):emptysemantics despite the editor-only placeholder childWhy
ContainerEditoralready removes its empty-state affordance when a node has a directly assigned class or inline styles. Ambient selectors such as.dots iattach through CSS matching and are therefore invisible to that component-level check. The authored empty element was correctly styled, but the striped “Empty container” chrome remained visible over it.The fix lets the browser use the same ambient selector matching as the authored stylesheet and hides only the direct editor-placeholder child. Published markup is unchanged.
User impact
Empty decorative elements styled through descendant, sibling, attribute, state, selector-list, or
:emptyambient rules now preview without Instatic’s empty-state chrome. The selectable canvas root remains intact.Verification
bun test— 6,262 passed, 0 failedbun run buildbun run lintbunx tsc -b --noEmit.dotsparent and empty custom<i>child.dots iambient width, height, background, and radiusdisplay: nonein mobile, tablet, and desktop canvas frames<i>has no children and identical authored styling