fix(svg): preserve text path references - #265
Merged
Merged
Conversation
DavidBabinec
marked this pull request as ready for review
July 24, 2026 18:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
hrefandxlink:hrefattributes required by inline SVG fragment references such as<textPath href="#ring">Why
Super Import correctly mapped the SVG element, but the shared SVG sanitizer blanket-removed both reference attributes, disconnecting
<textPath>from its<path>. Once those safe references were preserved, live testing exposed a second mismatch: the canvas used strict XML parsing and rejected common inline-HTML SVG that usesxlink:hrefwithout an explicit namespace declaration. Published pages parse that markup as HTML, so the canvas now matches the real rendering context.Impact
Circular SVG text now survives Super Import, editor save/reload, responsive canvas rendering, and publish. DOMPurify remains responsible for URI-scheme validation, and script,
foreignObject, nested anchors, JavaScript URIs, and data-URI<use>payloads remain blocked.Verification
bun test— 6,279 passed, 0 failedbun run lintbun run build/sealpage